Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting share expire date and password on creation impossible if fields are required by server #7246

Closed
ckamm opened this issue Jun 16, 2019 · 3 comments
Assignees
Labels
feature:sharing p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Jun 16, 2019

If the server security settings say a password or expire date is required it becomes impossible to create public link shares: In the share creation dialog the checkboxes for enabling expire dates or passwords are disabled and unchecked.

They should be disabled and checked to allow users to set an expire date or a password before creating the link share.

Found while investigating #7245

@ckamm ckamm added type:bug feature:sharing p2-high Escalation, on top of current planning, release blocker labels Jun 16, 2019
@ckamm ckamm added this to the 2.6.0 milestone Jun 16, 2019
@ckamm ckamm self-assigned this Jun 16, 2019
ckamm added a commit that referenced this issue Jun 16, 2019
Since the check boxes are disabled users can't check them themselves.

For #7246
ckamm added a commit that referenced this issue Jun 17, 2019
Since the check boxes are disabled users can't check them themselves.

For #7246
@ckamm
Copy link
Contributor Author

ckamm commented Jun 17, 2019

QA: Verify that creating and editing of public link shares is possible with permutations of these server sharing options:

  • "Set default expiration date"
  • "Enforce expiration date"
  • "Enforce password"

Need to restart client after changing server settings.

Note that the "Enforce password" setting was split into three options for 10.2.0 and that's not yet reflected in the client dialog. See #7247

@micbar
Copy link
Contributor

micbar commented Jun 17, 2019

@ckamm please evaluate owncloud/core#35564

ckamm added a commit that referenced this issue Jun 18, 2019
Since the check boxes are disabled users can't check them themselves.

For #7246
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Jun 18, 2019
@HanaGemela
Copy link
Contributor

Creating and editing of public link shares is possible when password and/or expiry date is enforced 2.6.0alpha2 (build 12128), macOS 10.14.5

NOTE: There are still some issues opened around this area

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:sharing p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Development

No branches or pull requests

3 participants