Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions options not shown when only single option is available for a public link #7429

Closed
HanaGemela opened this issue Aug 26, 2019 · 6 comments
Assignees
Labels
Design & UX Enhancement p3-medium Normal priority ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@HanaGemela
Copy link
Contributor

HanaGemela commented Aug 26, 2019

Server: 10.3.0 alpha
Client: 2.5.4 (build 11415)

Steps to recreate:

  1. Disable 'Allow public uploads' in server sharing setting
  2. Create a new public link with Download/View permissions

Actual result: No options to pick permissions
Expected result: User can see what permissions are set on the public link - Download/View option is shown, pre-selected and greyed out. Other options not shown at all

Screenshot 2019-08-26 at 11 04 05

@HanaGemela HanaGemela added type:bug p3-medium Normal priority labels Aug 26, 2019
@HanaGemela HanaGemela added this to the 2.6.1 milestone Aug 26, 2019
@HanaGemela HanaGemela changed the title [10.3.0 alpha] Cannot set permissions for a folder public sharing [10.3.0 alpha] Cannot set permissions for a public ink Aug 26, 2019
@HanaGemela HanaGemela changed the title [10.3.0 alpha] Cannot set permissions for a public ink [10.3.0 alpha] Cannot set permissions for a public link Aug 26, 2019
@HanaGemela
Copy link
Contributor Author

The same for files

@HanaGemela
Copy link
Contributor Author

The below is server 10.2. where user can select the permissions

Screenshot 2019-08-26 at 17 29 30

@HanaGemela HanaGemela changed the title [10.3.0 alpha] Cannot set permissions for a public link Cannot set permissions for a public link Aug 26, 2019
@ckamm
Copy link
Contributor

ckamm commented Aug 27, 2019

For files one never sees the permission combo box. Users cannot upload via file link shares ever, as far as I'm aware.

For link-shared directories:

  • if the files_sharing/public/upload capability is enabled, the permission selection is shown
  • if the files_sharing/public/supports_upload_only capability is enabled, the "Upload only" option is shown

@ckamm ckamm changed the title Cannot set permissions for a public link Permissions options not shown when only single option is available for a public link Aug 27, 2019
@ckamm
Copy link
Contributor

ckamm commented Aug 27, 2019

Ok, I think I understand what you mean: You'd prefer if the single available option was visible.

@HanaGemela
Copy link
Contributor Author

@ckamm yes, I think users should know what permissions the link has. So we should show them all available options (even though in this case it is only one single option)

@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Sep 2, 2019
@ckamm ckamm modified the milestones: 2.6.1, 2.6.0 Sep 2, 2019
@ckamm ckamm self-assigned this Sep 2, 2019
@HanaGemela
Copy link
Contributor Author

Works as expected on client 2.6.0rc1 (build 12411), mac 10.14.6

ogoffart added a commit that referenced this issue Feb 4, 2020
Re-apply part of commit f638f33
(for issue #7429) that were gone in the previous merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX Enhancement p3-medium Normal priority ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants