Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Files with .owncloud suffix on the server cause a syncing loop #7556

Closed
jnweiger opened this issue Oct 25, 2019 · 7 comments
Closed

[QA] Files with .owncloud suffix on the server cause a syncing loop #7556

jnweiger opened this issue Oct 25, 2019 · 7 comments
Milestone

Comments

@jnweiger
Copy link
Contributor

  • Connect Linux client 2.6.0rc2 to owncloud server 10.3
  • Wait until initial sync is done.
  • Pause syncing.
  • upload the same file three times to the server with the web GUI like this:
    • upload adler05.jpg and rename on the server to adler05.jpg.owncloud.owncloud
    • upload adler05.jpg and rename on the server to adler05.jpg.owncloud
    • upload adler05.jpg
  • resume syncing.

The client downloads all three of them:
image

3& [testy:~/ownCloud5] $ ll adl*
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg.owncloud
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg.owncloud.owncloud

OK so far.

  • enable virtual files ; wait for a sync -> Nothing changes.
  • switch 'Availability' -> 'Free up local space'

The client starts looping.
image

and contents of at least one file is lost:

3& [testy:~/ownCloud5] $ ll adl*
-rw-r--r-- 1 testy testy     1 Mai 12 01:10 adler05.jpg.owncloud
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg.owncloud.owncloud
3& [testy:~/ownCloud5] $ 
@jnweiger
Copy link
Contributor Author

related issue: #6953

@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 25, 2019

when we switch back to 'Availability' -> 'Make always available locally' the looping stops, but we lost one file:

3& [testy:~/ownCloud5] $ ll adl*
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg
-rw-r--r-- 1 testy testy 99226 Mai 12 01:10 adler05.jpg.owncloud.owncloud
3& [testy:~/ownCloud5] $ 

@ogoffart
Copy link
Contributor

Note: in order to reproduce the "looping", one need to "force sync"

@jnweiger
Copy link
Contributor Author

@ogoffart Force sync is not needed here to reproduce. The client immediately starts looping after switching the availability.

@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 28, 2019

when instead switching back directly from VFS with "freed local space" to non-VFS, then all three files are restored correctly.

The behaviour seems non-deterministic. Sometimes one or two files get lost on the client, but all three are on the server still. Sometimes one or two files get lost on both sides.
Running a force sync in between more often prevents the data loss for me than triggering it.

@ogoffart
Copy link
Contributor

I couldn't reproduce the problem unless i do force sync. Maybe there is something that make the client not "trust" the filesystem watcher

ogoffart added a commit that referenced this issue Oct 30, 2019
For issue #7557 and #7556

Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
@jnweiger jnweiger added this to the 2.6.1 milestone Oct 30, 2019
ogoffart added a commit that referenced this issue Oct 30, 2019
For issue #7557 and #7556

Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
ogoffart added a commit that referenced this issue Nov 1, 2019
For issue #7557 and #7556

Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
ogoffart added a commit that referenced this issue Nov 1, 2019
For issue #7557 and #7556

Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
guruz pushed a commit that referenced this issue Nov 3, 2019
For issue #7557 and #7556

Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
@michaelstingl michaelstingl modified the milestones: 2.6.1, 2.6.2 Nov 26, 2019
@jnweiger
Copy link
Contributor Author

jnweiger commented Jan 15, 2020

The loop no longer happens. We see an apropriate error message, that was introduced in 48d3c84
image

All 3 files remain as they are. No data loss seen on the client.
Disable virtual files also preserves the files.

@jnweiger jnweiger modified the milestones: 2.6.2, 2.6.1 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants