-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ocis][gui-test] Running GUI tests with oCIS server (using browser automation) #10261
Conversation
b672d8f
to
0e9ac82
Compare
78266fd
to
a35f1ef
Compare
implement browser login for oCIS server allow OCIS env var move to helpers and POs separate selector for basic and oauth page
use custom displaystring for ocis make Personal as ocis default sync path
run headless browser fix python style bring back middleware host
refactor cast string to bool handle error set browsers location
61dd624
to
ba571ce
Compare
a46623e
to
3c01059
Compare
Results for GUI-tests-ocis https://drone.owncloud.com/owncloud/client/13727/7/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/13727/ocis/guiReportUpload/index.html |
13f12b5
to
420fca0
Compare
420fca0
to
7f4bbad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done ! 🚀
just some small comments
# The account menu does not have its unique identifier | ||
# So we are clicking at (718, 27) of "stack_folderList_QTreeView" object | ||
item_text = "Personal" if context.userData['ocis'] else "ownCloud" | ||
squish.mouseClick( | ||
squish.waitForObjectItem(names.stack_folderList_QTreeView, item_text), | ||
718, | ||
27, | ||
squish.Qt.NoModifier, | ||
squish.Qt.LeftButton, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be really an issue in the future, could you please open an issue, so that the developers could add a good identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only small thing other looks 🚀 🚀
Kudos, SonarCloud Quality Gate passed! |
Enable GUI test run with oCIS server.
oCIS server uses oidc to authorize the user which prevents Squish to handle user authorization process (squish cannot handle authorization via browser). This PR extends the Squish tests with Playwright (browser automation) so that the authorization via browser can be done in the tests.
Some tests are skipped for oCIS server due to UI difference or lack of functionality:
Scenario: Adding account with wrong credentials
Scenario: Sync all is selected by default
Scenario: Sync only one folder from the server
Scenario: sort folders list by name and size
Scenario Outline: File with long name (233 characters) is blacklisted
all
Related Issues
Closes #10262, #10249
GUI test reports
oCIS: https://cache.owncloud.com/public/owncloud/client/13727/ocis/guiReportUpload/index.html
oC10: https://cache.owncloud.com/public/owncloud/client/13727/oc10/guiReportUpload/index.html
Todo
Noticeable Changes
CI pipelines for oC10 and oCIS
GitHub comment for each server
Chat notification on failure (combined)