Fix early-use crash in folder watcher on Linux #11475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/fix-linux-folderwatcher-crash
branch
from
a4bf609 to
f32f86d
Compare
In a few error scenarios (out-of-memory or out-of-space), the folder watcher on Linux shows a dialog with an error message. If this occurs during start-up before the GUI is initialised, this will lead to a crash. This is fixed by delaying the VFS start until after event loop is started, guaranteeing that the GUI is up and running. Fixes: #11460
erikjv
force-pushed
the
work/fix-linux-folderwatcher-crash
branch
from
f32f86d to
9f054fe
Compare
TheOneRing
approved these changes
Jan 17, 2024
delete-merged-branch
bot
deleted the
work/fix-linux-folderwatcher-crash
branch
erikjv
added a commit
that referenced
this pull request
Jan 18, 2024
This is the fix for the crash in the folder watcher on Linux
TheOneRing
pushed a commit
that referenced
this pull request
Jan 18, 2024
This is the fix for the crash in the folder watcher on Linux
TheOneRing
pushed a commit
that referenced
this pull request
May 22, 2024
This is the fix for the crash in the folder watcher on Linux (cherry picked from commit e170464)
TheOneRing
pushed a commit
that referenced
this pull request
May 23, 2024
This is the fix for the crash in the folder watcher on Linux (cherry picked from commit e170464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few error scenarios (out-of-memory or out-of-space), the folder watcher on Linux shows a dialog with an error message. If this occurs during start-up before the GUI is initialised, this will lead to a crash.
This is fixed by delaying the VFS start until after event loop is started, guaranteeing that the GUI is up and running.
Fixes: #11460