Skip to content

Remove unused fields in ETagWatcher #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Remove unused fields in ETagWatcher #12241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/gui/scheduling/etagwatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ void ETagWatcher::slotFolderListChanged()
QString spaceId = f->definition().spaceId();
auto &info = _lastEtagJobForSpace[spaceId];
info.etag = etag;
info.lastUpdate.reset();
if (f->accountState()) {
f->accountState()->tagLastSuccessfulETagRequest(time);
}
Expand Down Expand Up @@ -93,7 +92,6 @@ void ETagWatcher::updateEtag(const QString &spaceId, const QString &etag)
_folderMan->scheduler()->enqueueFolder(info.folder);
}
}
info.lastUpdate.reset();
} else {
qCWarning(lcEtagWatcher) << "Invalid empty etag received for space" << spaceId;
}
Expand Down
3 changes: 0 additions & 3 deletions src/gui/scheduling/etagwatcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

#pragma once

#include "common/chronoelapsedtimer.h"
#include "libsync/graphapi/space.h"

#include <QObject>
Expand Down Expand Up @@ -45,8 +44,6 @@ public Q_SLOTS:
{
QString etag;
Folder *folder;
// only used with oc10 in order to decide whether we need to query the etag
Utility::ChronoElapsedTimer lastUpdate;
};

std::unordered_map<QString, ETagInfo> _lastEtagJobForSpace;
Expand Down
Loading