Fix compatibility with extra-cmake-modules-6.19.0 #12374
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
owncloud is not using a custom QQmlExtensionPlugin subclass, so we need
to pass GENERATE_PLUGIN_SOURCE so that a default implementation is generated.
This fixes compatibility with ECM 6.19 since that (correctly) considers plugins
that don't use GENERATE_PLUGIN_SOURCE to be not optional [0]. That causes the
QML engine to try and load the (invalid) plugin:
```
QList(qrc:/qt/qml/org/ownCloud/gui/qml/AccountBar.qml:18:1: Failed to extract plugin
meta data from '/usr/lib64/qt6/qml/org/ownCloud/gui/libowncloudGuiplugin.so':
'/usr/lib64/qt6/qml/org/ownCloud/gui/libowncloudGuiplugin.so' is not a Qt plugin (metadata not found)
import org.ownCloud.gui 1.0
^)
```
Pass GENERATE_PLUGIN_SOURCE to fix the startup problem.
[0] commit 4e9b73da40792ece7885924007441880ecc06d8d
Bug: https://bugs.gentoo.org/964420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
owncloud is not using a custom QQmlExtensionPlugin subclass, so we need to pass GENERATE_PLUGIN_SOURCE so that a default implementation is generated.
This fixes compatibility with ECM 6.19 since that (correctly) considers plugins that don't use GENERATE_PLUGIN_SOURCE to be not optional [0]. That causes the QML engine to try and load the (invalid) plugin:
Pass GENERATE_PLUGIN_SOURCE to fix the startup problem.
[0] commit 4e9b73da40792ece7885924007441880ecc06d8d
Bug: https://bugs.gentoo.org/964420