Always follow redirects in network jobs #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Actually, since _followRedirects is always true, we could get rid of it. |
|
@ogoffart I intentionally left it there for jobs to customize, but we could just as well kill it. |
|
Olivier also mentioned that this change makes HTTP only connections prey to redirects from mobile hotspots, which could mess with data integrity. We need to find a good solution here, even if it means disabling redirects for HTTP only. |
|
👎 Please mention the issue ID in the commit and check if this confirms.. |
|
Behaviour change, move to 2.3? |
This is a move away from the original policy where jobs would only follow redirects in special cases. Two restrictions are in place: 1. We do not allow protocol downgrades (https -> http) 2. We stop redirects after we find them looping (e.g. old = new url, or indirectly when looping 10 times). This is closer to RFC conforming behavior, although currently we will treat 301 replies like they were 302. This is for a separate commit. Error handling (and display) also needs improvement. Addresses #2791
|
👍 |
|
We discussed irl that this is not as dangerous as we thought and that we should go for it. |
|
@guruz: build has passed. +1? |
|
I don't want to take responsibility for this |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a move away from the original policy where jobs would only follow
redirects in special cases.
Two restrictions are in place:
times).
This is closer to RFC conforming behavior, although currently we will treat
301 replies like they were 302. This is for a separate commit.