Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist: Don't let errors become warnings #5516 #5865

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Jun 27, 2017

Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.

Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
@ckamm ckamm added this to the 2.4.0 milestone Jun 27, 2017
@ckamm ckamm self-assigned this Jun 27, 2017
@ckamm ckamm requested review from ogoffart and guruz June 27, 2017 12:21
@guruz
Copy link
Contributor

guruz commented Jul 3, 2017

Code looks 👍
CI failure from disk full, let's wait for retrigger..
@DeepDiver1975

@ckamm
Copy link
Contributor Author

ckamm commented Jul 4, 2017

@guruz CI is good, can me merged?

@guruz
Copy link
Contributor

guruz commented Jul 4, 2017

I didn't see the Ci go good on this yet, i thought it should have been retriggered but wasn't.
I'll merge anwyway and we need to watch the commit list for CI.

@guruz guruz merged commit b1aaf05 into master Jul 4, 2017
@guruz guruz deleted the blacklist-show-as-error branch July 4, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants