Credentials: Use per-account keychain entries #5830 #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a lot of migration code: the old entries need to be read, saved to the new locations and then deleted.
ogoffart
suggested changes
Sep 14, 2017
| { | ||
| auto startDeleteJob = [this](QString user) { | ||
| DeletePasswordJob *job = new DeletePasswordJob(Theme::instance()->appName()); | ||
| addSettingsToJob(_account, job); |
There was a problem hiding this comment.
In HttpCredentials::invalidateToken, there is a job2 to remove the password from a "deprecated location" which does not set the settings.
Should we not do the same here? (in case of upgrading from a 1.7 client? maybe this is anyway no longer supported)
But in any case, we can remove this job2 from HttpCredentials::invalidateToken
|
@ogoffart Done |
ogoffart
approved these changes
Sep 14, 2017
|
I guess the jenkins failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a lot of migration code: the old entries need to be read,
saved to the new locations and then deleted.
See #5830. It's potentially breaking, so please review carefully.
Known side effects of this patch:
While working on this I had an idea about an alternate approach: What if we added a "what's the keychain base id" entry to the settings? Then we could add the new account identifier to new accounts and old accounts would work without losing keychain data even when switching between 2.3 and 2.4. The drawback is that we'd never migrate old accounts.