Wizard + OAuth: Make opening a new browser after clicking back works again #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, this is a very corner case issue. Not worth backporting IMHO. |
ckamm
approved these changes
Jun 19, 2018
src/gui/creds/oauth.cpp
Outdated
| @@ -85,6 +86,8 @@ void OAuth::start() | |||
| QString basicAuth = QString("%1:%2").arg( | |||
| Theme::instance()->oauthClientId(), Theme::instance()->oauthClientSecret()); | |||
| req.setRawHeader("Authorization", "Basic " + basicAuth.toUtf8().toBase64()); | |||
| // We just added the Authorization header, don't let HttpCredentialsAccessManager temper with it | |||
…again Issue #6574 When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus (and others) call completeChanged(), which is connected to QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the last page. When the user click "back" and re-open the browser, the account's credentials already have a oauth token set. So the call to the API to get a new token fails because we use the previous token instead of using the client's secret_id. Fix this with the HttpCredentials::DontAddCredentialsAttribute. Now, this is still not working because the session cookies are confusing the server. So we'll clear the cookies when re-opening the browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6574
When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.
When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.
Now, this is still not working because the session cookies are confusing the
server. So we'll clear the cookies when re-opening the browser