Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autostartCheckbox if autostart is configured system wide #6816

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

dschmidt
Copy link
Member

No description provided.

@dschmidt
Copy link
Member Author

dschmidt commented Oct 16, 2018

Hehe, the monoIconsCheckbox apparently was already at the bottom because it can be hidden by the theme ... suggestions how to handle this without overcomplicating the code?

Easiest would be not to have two columns...

Copy link
Contributor

@guruz guruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions how to handle this without overcomplicating the code?

Don't hide the checkbox, just disable it and make it checked so it's clear that it is system wide and not over-ridable.

@guruz guruz added this to the 2.5.1 milestone Oct 16, 2018
@dschmidt
Copy link
Member Author

I like that! Will do!

@dschmidt
Copy link
Member Author

Tested on Win7 and Win10.

@dschmidt dschmidt changed the title Hide autostartCheckbox if autostart is configured system wide Disable autostartCheckbox if autostart is configured system wide Oct 17, 2018
@guruz guruz merged commit e587ae7 into 2.5 Oct 19, 2018
@guruz guruz deleted the system-autostart branch October 19, 2018 08:45
@guruz
Copy link
Contributor

guruz commented Oct 20, 2018

(Forgot to mention issue ID in commit..i think with enterprise issues we often forget that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants