Vfs <=> selective sync switching #6954
Conversation
That would break with old folders that use selective sync.
I'm unsure this note is all that useful. Remove entirely?
Why? |
|
|
||
| // Wipe pin states to be sure | ||
| folder->journalDb()->wipePinStateForPathAndBelow(""); | ||
| folder->journalDb()->setPinStateForPath("", PinState::OnlineOnly); |
There was a problem hiding this comment.
should we not set the oldBlackList as Online Only ?
There was a problem hiding this comment.
By setting the root as OnlineOnly everything will be online-only - there's no attempt to migrate selective sync settings. If we had the root as AlwaysLocal, users who switch to vfs but have no selective sync configured would see no difference. See PR text above.
src/gui/accountsettings.cpp
Outdated
| QMessageBox::Question, | ||
| tr("Disable virtual file support?"), | ||
| tr("This action will disable virtual file support. As a consequence contents of folders that " | ||
| "are currently marked as 'available online only' will either be downloaded or excluded " |
There was a problem hiding this comment.
I believe they will all be downloaded
There was a problem hiding this comment.
Yes, old text from when I migrated.
It has a destructor and these operations make sense. Particularly the
move is important for code like:
Result<x, y> foo() { Result<x, y> v; return v; }
because the move-ctor will not autogenerate if x or y are not trivially
destructible.
This allows enabling and disabling vfs. To distinguish this operation from setting the root pin state, the availability setting is adjusted as well to be similar to the menu that shows in the shell extensions.
ckamm
force-pushed
the
vfs-selective-sync-migration
branch
from
bc34a69
to
9811450
Compare
|
@ogoffart Please rereview |
|
I've merged this since other pr depends on it. |
There is now a local/online availability switch on folder context menus in the settings as well as a menu entry to switch into vfs mode and away from it.
I looked at migrating between the two analogous settings (selective sync excluded <-> vfs online-only) but it's complex and will probably not produce exactly what users want. So instead I just start with blank vfs and selective sync settings after switching.
Details: When switching on vfs it seems natual to make all excluded paths online-only, the rest available-locally. But then switching on vfs has no visible effect for users that didn't use selective sync unless they manually also switch folders to online-only.
Migrating from vfs to selective sync is just hard since vfs can have arbitrary switches back and forth between online/local folders. Also, online-only folders can totally have locally available files - so setting up selective sync options automatically from that is likely not worth it.
@michaelstingl FYI