Client certs: Store pkcs12 in config, password in keychain #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Feb 28, 2019
| return; | ||
| } | ||
|
|
||
| // Old case: Read client cert and then key from keychain |
There was a problem hiding this comment.
Maybe mention the version (< 1.6)
| _clientCertPassword.clear(); | ||
| } else if (_account->credentialSetting(QLatin1String(clientCertBundleC)).isNull() && !_clientSslCertificate.isNull()) { | ||
| // Option 2, older configs: We used to store the raw cert/key in the keychain and | ||
| // still do so if no bundle is available. |
There was a problem hiding this comment.
So that means we are not migrating away from that setting?
|
I'd also prefer migrating. The issue is that I don't think we currently have functions for creating an encrypted pkcs12 bundle or some other strong symmetric encryption available. |
It still reads and writes the old format too, but all newly stored client certs will be in the new form. For #6776 because Windows limits credential data to 512 bytes in older versions.
ckamm
force-pushed
the
store-long-clientcert
branch
from
1063f8c
to
d320cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still reads and writes the old format too, but all newly stored
client certs will be in the new form.
For #6776 because Windows limits credential data to 512 bytes in older
versions.