Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogWindow: Remove output, add "go to log folder" button #7093

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Mar 15, 2019

For #6475

image

@ckamm ckamm added this to the 2.6.0 milestone Mar 15, 2019
@ckamm ckamm self-assigned this Mar 15, 2019
@ckamm ckamm requested a review from guruz March 15, 2019 11:15
@guruz
Copy link
Contributor

guruz commented Mar 15, 2019

How is the --logdebugflag handled now?

@michaelstingl
Copy link
Contributor

😍 /cc @ChrisEdS FYI

@ckamm
Copy link
Contributor Author

ckamm commented Mar 19, 2019

@guruz The persistent logging is always with --logdebug.

@ckamm ckamm force-pushed the 6475-simple-logdir branch from daa0fd4 to 7e8beb8 Compare March 28, 2019 07:48
@ckamm
Copy link
Contributor Author

ckamm commented Mar 28, 2019

Further updated with doc changes and a new screenshot of the log output window.

@guruz guruz requested a review from ogoffart April 9, 2019 08:34
@guruz
Copy link
Contributor

guruz commented Apr 9, 2019

Hmmm I don't really think it's necessary to tr() in this window but i don't have a strong opinion on this

@ckamm ckamm force-pushed the 6475-simple-logdir branch from 7e8beb8 to 184e730 Compare April 9, 2019 11:14
@ckamm ckamm merged commit fcf2af3 into master Apr 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the 6475-simple-logdir branch April 9, 2019 11:15
@guruz
Copy link
Contributor

guruz commented Apr 10, 2019

Ugly on windows directly after pressing the Fx key:
Screen Shot 2019-04-10 at 11 48 25

@ckamm
Copy link
Contributor Author

ckamm commented Apr 10, 2019

@guruz I've adjusted the layout to look a bit better. There's still some unnecessary whilespace but it's in a better location now. And it's just the debug log window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants