Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Drone 1.x and handle translations in this repo #7426

Merged
merged 22 commits into from
Aug 27, 2019
Merged

Port to Drone 1.x and handle translations in this repo #7426

merged 22 commits into from
Aug 27, 2019

Conversation

dschmidt
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dschmidt
❌ ownclouders
You have signed the CLA already but the status is still pending? Let us recheck it.

@dschmidt dschmidt changed the base branch from master to 2.6 August 26, 2019 18:08
@ckamm
Copy link
Contributor

ckamm commented Aug 27, 2019

@dschmidt Why is there a transifex commit in the PR?

@dschmidt
Copy link
Member Author

@dschmidt Why is there a transifex commit in the PR?

Basically "because the PR works" :trollface:

I configured the cron job so it runs on my branch. Probably I forked between a commit and the next transifex run, that's why there are a few changes. Subsequent runs did not trigger further commits as you can see:
https://drone.owncloud.com/owncloud/client/

(also because I made the order of NSIS translations stable)

When merged I will change the cron job to the 2.6 branch and raise the execution interval back to @daily.

@ckamm
Copy link
Contributor

ckamm commented Aug 27, 2019

Ok!

Copy link
Contributor

@ckamm ckamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an in-depth review, but looks sane.

@dschmidt dschmidt merged commit 2801455 into 2.6 Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the 2.6-l10n branch August 27, 2019 07:43
@guruz
Copy link
Contributor

guruz commented Sep 4, 2019

Please next time prefix your commit messages with the topic, e.g. "drone:" or "translations:"
thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants