-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Drone 1.x and handle translations in this repo #7426
Conversation
|
3ddab85
to
bf4fe5d
Compare
Before this was done in translation-sync repo because we had no drone cron jobs.
You might accidentally add, commit and push files not meant for public. Make sure your working directory is clean before testing this and possibly set a bogus remote name which will make the push fail.
The parameter is already unused as the target branch is determined by DRONE_BRANCH. This is okay, because the translation cron always triggers a specific branch.
@dschmidt Why is there a transifex commit in the PR? |
Basically "because the PR works" I configured the cron job so it runs on my branch. Probably I forked between a commit and the next transifex run, that's why there are a few changes. Subsequent runs did not trigger further commits as you can see: (also because I made the order of NSIS translations stable) When merged I will change the cron job to the 2.6 branch and raise the execution interval back to |
Ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an in-depth review, but looks sane.
Please next time prefix your commit messages with the topic, e.g. "drone:" or "translations:" |
No description provided.