-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] remove connection #8682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoichha
force-pushed
the
test-user-remove
branch
2 times, most recently
from
June 4, 2021 10:32
ad6c895
to
660cf9f
Compare
Talank
suggested changes
Jun 4, 2021
Talank
reviewed
Jun 4, 2021
swoichha
force-pushed
the
test-user-remove
branch
from
June 4, 2021 11:17
bc9191d
to
7bcd72a
Compare
Talank
reviewed
Jun 4, 2021
Talank
reviewed
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
individual-it
requested changes
Jun 4, 2021
individual-it
requested changes
Jun 7, 2021
individual-it
approved these changes
Jun 7, 2021
swoichha
force-pushed
the
test-user-remove
branch
from
June 7, 2021 08:44
e1adc84
to
c53194f
Compare
Talank
approved these changes
Jun 7, 2021
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for removing connection after a user has been added to the desktop-client
Related Issue