Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Group share tests added #8695

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[tests-only] Group share tests added #8695

merged 1 commit into from
Jul 15, 2021

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Jun 8, 2021

The following test scenarios have been added:

  • Collaborator should not see to whom a file is shared.
  • Group sharing
  • User (non-author) can not share to a group to which the file is already shared

Related issues:

@Talank Talank force-pushed the group-share-tests branch 3 times, most recently from 1116b3f to 7955c93 Compare June 11, 2021 06:54
@Talank Talank force-pushed the group-share-tests branch 3 times, most recently from 7e0c5c6 to 61d49bc Compare June 21, 2021 11:09
@Talank Talank force-pushed the group-share-tests branch 5 times, most recently from 979d6c0 to 56675a8 Compare June 28, 2021 11:41
@Talank Talank changed the title Group share tests added [tests-only] Group share tests added Jun 28, 2021
@Talank Talank force-pushed the group-share-tests branch 2 times, most recently from 07ef6b6 to 932ca7c Compare June 28, 2021 14:48
@Talank Talank marked this pull request as ready for review June 29, 2021 04:01
@Talank Talank requested a review from swoichha June 29, 2021 04:01
@Talank Talank force-pushed the group-share-tests branch 2 times, most recently from 8f8f1c9 to 3d0e050 Compare June 29, 2021 04:16
@Talank Talank self-assigned this Jun 29, 2021
@@ -646,3 +672,24 @@ def step(context):
def step(context):
for tabName in context.table:
test.vp(tabName[0])


@Then('the error "|any|" should be displayed')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also mention where this error is to be displayed like you have done in line 466

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it looks for an error label that can be found using the selector {"name": "errorLabel", "type": "QLabel", "visible": 1}. So, I think it should work for any error in general. 🤔 And IMO mentioning where the error is (for example ... should be displayed in sharing dialog) brings more confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this way is better then that's fine. I just mentioned it because this step seems a bit generic.

test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@Talank Talank requested a review from swoichha June 29, 2021 08:09
@Talank
Copy link
Contributor Author

Talank commented Jul 2, 2021

Need to run after scenario to cleanup the state from middleware before merging this PR. So, blocked until #8792 is merged.

@Talank Talank force-pushed the group-share-tests branch 3 times, most recently from 15bc6a2 to 537a8a9 Compare July 13, 2021 12:45
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Talank Talank merged commit 89c18b6 into master Jul 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the group-share-tests branch July 15, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants