-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Group share tests added #8695
Conversation
1116b3f
to
7955c93
Compare
7e0c5c6
to
61d49bc
Compare
979d6c0
to
56675a8
Compare
07ef6b6
to
932ca7c
Compare
8f8f1c9
to
3d0e050
Compare
test/gui/shared/steps/steps.py
Outdated
@@ -646,3 +672,24 @@ def step(context): | |||
def step(context): | |||
for tabName in context.table: | |||
test.vp(tabName[0]) | |||
|
|||
|
|||
@Then('the error "|any|" should be displayed') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also mention where this error is to be displayed like you have done in line 466
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it looks for an error label that can be found using the selector {"name": "errorLabel", "type": "QLabel", "visible": 1}
. So, I think it should work for any error in general. 🤔 And IMO mentioning where the error is (for example ... should be displayed in sharing dialog
) brings more confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this way is better then that's fine. I just mentioned it because this step seems a bit generic.
Need to run after scenario to cleanup the state from middleware before merging this PR. So, blocked until #8792 is merged. |
15bc6a2
to
537a8a9
Compare
537a8a9
to
08ef2db
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following test scenarios have been added:
Related issues: