Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Visually check all tabs #8725

Merged
merged 1 commit into from
Jun 18, 2021
Merged

[Tests-Only] Visually check all tabs #8725

merged 1 commit into from
Jun 18, 2021

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Jun 14, 2021

Description

This PR adds test to check if all the tabs in toolbar section is visible by property verification point creation and suing squish api test.vp

Related Issue

Also see: #8651 (comment)

@swoichha swoichha changed the title "[Tests-Only] Visually check all tabs" [Tests-Only] Visually check all tabs Jun 14, 2021
@swoichha swoichha self-assigned this Jun 14, 2021
@swoichha swoichha force-pushed the add-smokeTest branch 3 times, most recently from 2eb65b0 to 9bea5f6 Compare June 15, 2021 07:53
@swoichha swoichha marked this pull request as draft June 15, 2021 09:18
@swoichha swoichha force-pushed the add-smokeTest branch 5 times, most recently from 60b40ed to 3366f26 Compare June 17, 2021 07:47
@swoichha swoichha requested a review from Talank June 17, 2021 08:02
@swoichha swoichha marked this pull request as ready for review June 17, 2021 08:02
@swoichha swoichha requested a review from Talank June 17, 2021 11:07
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails with some linting issue, not sure if its related

test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@swoichha
Copy link
Contributor Author

CI fails with some linting issue, not sure if its related

It has nothing to so with this PR. test-clang-format has been failing in CI for 2 days now.

test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash on merge

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit f282e37 into master Jun 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-smokeTest branch June 18, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants