Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] change collaborator permissions #8788

Merged
merged 1 commit into from
Jul 1, 2021
Merged

[tests-only] change collaborator permissions #8788

merged 1 commit into from
Jul 1, 2021

Conversation

swoichha
Copy link
Contributor

Description

This PR adds test for changing collaborator permissions got files/folder.

Related Issue

#8651

@swoichha swoichha self-assigned this Jun 28, 2021
@swoichha swoichha requested a review from Talank June 28, 2021 10:58
@swoichha swoichha marked this pull request as ready for review June 28, 2021 10:58
Talank
Talank reviewed Jun 29, 2021
View reviewed changes
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/pageObjects/SharingDialog.py Outdated Show resolved Hide resolved
@swoichha swoichha requested a review from Talank June 29, 2021 07:56
Talank
Talank reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion.
All in all, it looks good to me

test/gui/shared/scripts/pageObjects/SharingDialog.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/pageObjects/SharingDialog.py Outdated Show resolved Hide resolved
@swoichha swoichha requested a review from Talank June 29, 2021 10:57
Talank
Talank reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

individual-it
individual-it approved these changes Jun 29, 2021
View reviewed changes
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/tst_sharing/test.feature Outdated Show resolved Hide resolved
test/gui/tst_sharing/test.feature Outdated Show resolved Hide resolved
individual-it
individual-it requested changes Jun 29, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

individual-it
individual-it requested changes Jun 30, 2021
View reviewed changes
test/gui/tst_sharing/test.feature Outdated Show resolved Hide resolved
@swoichha swoichha mentioned this pull request Jun 30, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit ea03dab into master Jul 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-edit-share branch July 1, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@Talank Talank Talank left review comments

@individual-it individual-it individual-it approved these changes

Assignees

@swoichha swoichha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swoichha @phil-davis @individual-it @Talank