Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Add GUI tests for selective sync scenario (part-1) #9009

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[Tests-Only] Add GUI tests for selective sync scenario (part-1) #9009

merged 1 commit into from
Oct 26, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Sep 13, 2021

Description

Added automated tests for selective syncing

Related Issues

@saw-jan saw-jan self-assigned this Sep 13, 2021
@saw-jan saw-jan force-pushed the selective-sync-guitests branch 11 times, most recently from 89470ba to 64f1775 Compare September 17, 2021 15:05
@saw-jan saw-jan force-pushed the selective-sync-guitests branch 2 times, most recently from 6f162ae to 92a9fdc Compare September 22, 2021 04:13
Talank
Talank reviewed Sep 28, 2021
View reviewed changes
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
@saw-jan saw-jan force-pushed the selective-sync-guitests branch 3 times, most recently from b6e78d9 to f670062 Compare October 4, 2021 10:11
@saw-jan saw-jan requested a review from Talank October 4, 2021 10:11
Talank
Talank reviewed Oct 4, 2021
View reviewed changes
test/gui/tst_removeAccountConnection/test.feature Outdated Show resolved Hide resolved
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
@saw-jan saw-jan requested a review from Talank October 4, 2021 10:29
swoichha
swoichha reviewed Oct 4, 2021
View reviewed changes
.drone.env Outdated Show resolved Hide resolved
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@saw-jan
Copy link
Member Author

saw-jan commented Oct 5, 2021 •
edited
Loading

Can be merged only after PR #9115

@saw-jan saw-jan requested a review from swoichha October 5, 2021 05:33
Talank
Talank reviewed Oct 5, 2021
View reviewed changes
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@saw-jan saw-jan requested a review from Talank October 6, 2021 04:43
@saw-jan saw-jan requested a review from Talank October 6, 2021 06:19
@saw-jan saw-jan force-pushed the selective-sync-guitests branch 3 times, most recently from 7c12947 to 2a9604d Compare October 25, 2021 04:41
@saw-jan saw-jan requested a review from Talank October 25, 2021 10:51
swoichha
swoichha approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me

Talank
Talank approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

individual-it
individual-it requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the refactoring be placed into a separate PR or at least commit?

test/gui/shared/scripts/pageObjects/AccountConnectionWizard.py Show resolved Hide resolved
test/gui/tst_syncing/test.feature Outdated Show resolved Hide resolved
individual-it
individual-it requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rewords the commits so that its obvious what happens in the commits, squash them and if possible separate the refactoring from the new tests

@saw-jan
add gui tests for selective sync scenarios
017af8e 
add more tests for selective sync scenarios

address reviews

refactor test steps

address reviews
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit d4f52b1 into 2.9 Oct 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the selective-sync-guitests branch October 26, 2021 10:08
@saw-jan saw-jan mentioned this pull request Nov 3, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank approved these changes

@swoichha swoichha swoichha approved these changes

@individual-it individual-it individual-it approved these changes

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saw-jan @individual-it @swoichha @Talank