Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Added files tests from testplan #9273

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[tests-only] Added files tests from testplan #9273

merged 1 commit into from
Feb 15, 2022

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Dec 10, 2021 •
edited
Loading

Related Issue

part of #9396

Test automated

The following test from the testplan has been automated in this PR

Test scenario: User adds the various types of files 
Steps to reproduce:
1. Microsoft word documents, Microsoft Excel, Microsoft Powerpoint, .JPG, .PDF, .MP3
Result: The Sync files tab show all type of files added in the Desktop Client folder from desktop, All files snyced and shown in Activities Tab under synchronization protocol

I have automated test for syncing files from client to server and vice-versa

@Talank Talank changed the base branch from master to 2.10 December 10, 2021 07:08
@Talank Talank self-assigned this Dec 15, 2021
@Talank Talank added the QA:team label Dec 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Talank
Copy link
Contributor Author

Talank commented Jan 3, 2022

Can not create a file (in the GUI test). The not synced tab says that file was changed during synced. So, this PR is blocked until #9281 (comment) is fixed.

@Talank
Copy link
Contributor Author

Talank commented Jan 4, 2022

the issue #9281 has been closed as it has been splitted into specific issues. Now this PR is blocked until #9325 is fixed

@Talank
Copy link
Contributor Author

Talank commented Jan 31, 2022

The blocking issues has been fixed.

@Talank Talank changed the title [tests-only] Added files tests from testplan 2.9 [tests-only] Added files tests from testplan Feb 1, 2022
@Talank
Copy link
Contributor Author

Talank commented Feb 7, 2022

Files for upload issue is still not resolved in client. So the step And user "Alice" has uploaded file "testavatar.png" to "simple-folder/testavatar.png" on the server fails. We first need to either bump the middleware commit or use (and solve files for upload issue in) middleware's docker image.

@Talank Talank force-pushed the add-files-tests branch 3 times, most recently from de841ff to 299268f Compare February 15, 2022 08:06
@Talank Talank requested a review from saw-jan February 15, 2022 08:07
@Talank Talank requested a review from saw-jan February 15, 2022 09:05
saw-jan
saw-jan reviewed Feb 15, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Talank Talank requested review from individual-it and removed request for individual-it February 15, 2022 09:57
@Talank Talank mentioned this pull request Feb 15, 2022
Closed
@individual-it individual-it merged commit 2cd8baf into 2.10 Feb 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-files-tests branch February 15, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@individual-it individual-it individual-it approved these changes

Assignees

@Talank Talank

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Talank @individual-it @saw-jan