Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] add test for folder sync #9280

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[Tests-Only] add test for folder sync #9280

merged 1 commit into from
Dec 15, 2021

Conversation

swoichha
Copy link
Contributor

Description

This PR adds tests for Creating a new folder with space at the end and sync it.

Related Issue

#8971 (comment)

@swoichha swoichha self-assigned this Dec 13, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@swoichha swoichha changed the base branch from master to 2.10 December 13, 2021 08:53
Talank
Talank approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already had similar scenario, adding an example in the scenario outline will do the job.

saw-jan
saw-jan approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swoichha swoichha force-pushed the add-sync-test branch 2 times, most recently from e5716fc to 01c32f6 Compare December 14, 2021 03:45
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit c8dd64d into 2.10 Dec 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-sync-test branch December 15, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@Talank Talank Talank approved these changes

Assignees

@swoichha swoichha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swoichha @CLAassistant @Talank @saw-jan