Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Added more gui tests for sharing with user (Part 02) #9323

Closed
wants to merge 1 commit into from

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Dec 29, 2021

Description

Added more automated tests for different sharing scenarios

Related Issues

@saw-jan saw-jan self-assigned this Dec 29, 2021
@saw-jan saw-jan force-pushed the sharing-tests branch 3 times, most recently from 2d64363 to fce9647 Compare January 4, 2022 11:29
@saw-jan saw-jan mentioned this pull request Jan 6, 2022
15 tasks
@saw-jan saw-jan force-pushed the sharing-tests branch 5 times, most recently from b9f29f6 to a7f7f55 Compare January 18, 2022 07:34
@saw-jan saw-jan marked this pull request as ready for review January 18, 2022 07:40
@saw-jan saw-jan requested a review from Talank January 18, 2022 07:40
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fix code formats

fix rename tests

fix edit files tests

reduce aync timeout to 10 sec

fix edit files tests

combine test scenarios

skip expiration date tests

reuse steps

revert source code changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the "tries" steps

also please split the PR into smaller ones

@@ -380,6 +387,11 @@ def step(context, username, foldername):
createFolder(context, foldername, username)


@When('user "|any|" tries to create a folder "|any|" inside the sync folder')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an extra step here, that does the same thing as the one above?

actually the user does not only try to create a folder, the user creates a folder (on the local disk) but it might or might not get synced to the server.

Same for the steps with files

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan
Copy link
Member Author

saw-jan commented Jan 26, 2022

Splitted into #9388 and #9389

@saw-jan saw-jan closed this Jan 26, 2022
@saw-jan saw-jan deleted the sharing-tests branch February 14, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants