Fix translated icon names in desktop file #9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoc
force-pushed
the
work/fix-icons-mk2
branch
from
724810b to
fb97576
Compare
|
Please target 2.10. |
|
Is this file exclusively manually edited? Then this seems to be fine |
dschmidt
approved these changes
Jan 26, 2022
We used to have automatic translations from transifex for that file, until they stopped the support without notice. |
fmoc
force-pushed
the
work/fix-icons-mk2
branch
from
fb97576 to
71880bb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
TheOneRing
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #9150, which fixed the generic icon but not the translated ones. Those translated
Iconentries were completely redundant, so simply removing it fixes the issue and removes some bloat.The second commit fixes an (accidentally?) translated placeholder for the
ellocale.