Handle custom trusted CA certificates in our access manager #9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2022 23:44
Gives us access to its features (for instance, it sets the correct user agent).
Needed to be able to access planned TLS certificate handling related methods.
TheOneRing
suggested changes
May 6, 2022
fmoc
force-pushed
the
work/tls-handling-nam
branch
from
ad15fda to
ae62570
Compare
added 2 commits
May 6, 2022 10:51
This eliminates the need for hacks like changing the global state (e.g., by changing the default QSslConfiguration or using the deprecated QSslSocket methods).
fmoc
force-pushed
the
work/tls-handling-nam
branch
from
ae62570 to
c6130cd
Compare
|
Looks great, lets find out how it will blow up. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for an upcoming PR that implements a TLS error dialog in the wizard.
This PR extends the existing
AccessManagersubclass ofQNetworkAccessManagerwith TLS certificates management. Unfortunately, the default Qt class does not support this.This PR replaces all the hacks that altered the global state in order to make requests to servers using (previously untrusted) certificates work.