Restore sll error behaviour #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11785/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/11785/guiReportUpload/index.html |
TheOneRing
force-pushed
the
work/ignore_all_ssl_errors
branch
from
4835293 to
d493537
Compare
This matches the old behaviour
TheOneRing
force-pushed
the
work/ignore_all_ssl_errors
branch
from
d493537 to
4cc418c
Compare
fmoc
approved these changes
May 17, 2022
| @@ -40,6 +42,16 @@ AccessManager::AccessManager(QObject *parent) | |||
| setConfiguration(QNetworkConfiguration()); | |||
| #endif | |||
| setCookieJar(new CookieJar); | |||
|
|
|||
| connect(this, &AccessManager::sslErrors, this, [this](QNetworkReply *reply, const QList<QSslError> &errors) { | |||
There was a problem hiding this comment.
Can we make sure this slot is run first using some flag on connect?
There was a problem hiding this comment.
Thinking about it, maybe we should just debug log all erased errors. That way, whoever will work with this code in the future, will get notified about ignored errors.
|
Kudos, SonarCloud Quality Gate passed! |
Please open an issue for 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.