Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop socket api upload job #9996

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Drop socket api upload job #9996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20ad48
Drop socket api upload job
TheOneRing Aug 4, 2022
4fccdd8
Update changelog/unreleased/9585 [skip ci]
TheOneRing Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/9585
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Change: Drop socketupload job
TheOneRing marked this conversation as resolved.
Show resolved Hide resolved

https://github.com/owncloud/client/issues/9585
1 change: 0 additions & 1 deletion src/gui/socketapi/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
target_sources(owncloudCore PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/socketapi.cpp
${CMAKE_CURRENT_SOURCE_DIR}/socketuploadjob.cpp
)

if( APPLE )
Expand Down
8 changes: 0 additions & 8 deletions src/gui/socketapi/socketapi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
#include "socketapi.h"
#include "socketapi_p.h"

#include "socketapi/socketuploadjob.h"

#include "account.h"
#include "accountmanager.h"
#include "accountstate.h"
Expand Down Expand Up @@ -853,12 +851,6 @@ void SocketApi::command_V2_LIST_ACCOUNTS(const QSharedPointer<SocketApiJobV2> &j
job->success({ { QStringLiteral("accounts"), out } });
}

void SocketApi::command_V2_UPLOAD_FILES_FROM(const QSharedPointer<SocketApiJobV2> &job) const
{
auto uploadJob = new SocketUploadJob(job);
uploadJob->start();
}

void SocketApi::command_V2_GET_CLIENT_ICON(const QSharedPointer<SocketApiJobV2> &job) const
{
OC_ASSERT(job);
Expand Down
1 change: 0 additions & 1 deletion src/gui/socketapi/socketapi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ private slots:

// External sync
Q_INVOKABLE void command_V2_LIST_ACCOUNTS(const QSharedPointer<SocketApiJobV2> &job) const;
Q_INVOKABLE void command_V2_UPLOAD_FILES_FROM(const QSharedPointer<SocketApiJobV2> &job) const;

// Sends the id and the client icon as PNG image (base64 encoded) in Json key "png"
// e.g. { "id" : "1", "arguments" : { "png" : "hswehs343dj8..." } } or an error message in key "error"
Expand Down
223 changes: 0 additions & 223 deletions src/gui/socketapi/socketuploadjob.cpp
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions src/gui/socketapi/socketuploadjob.h
View file
Open in desktop

This file was deleted.