Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better colors generator #261

Merged
merged 2 commits into from
Mar 23, 2016
Merged

Better colors generator #261

merged 2 commits into from
Mar 23, 2016

Conversation

skjnldsv
Copy link
Contributor

A better color generator, with pastel colors and a brightness check to prevent illisible text.

I didn't liked the colors on the contacts app, so i made a color generator using the hsl wheel and a different angle base on the contact uid. I use a hsl to rgb function found online (too simple to bother coding the same function on my own) and a basic common brightness algorithm.

capture d ecran_2016-03-22_09-26-21

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Henni to be a potential reviewer

@DeepDiver1975 DeepDiver1975 added this to the 1.1-next milestone Mar 22, 2016
@irgendwie
Copy link
Contributor

@skjnldsv Would you mind squashing your last commit? (https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/)
LGTM 👍

Jenkins for ownCloud and others added 2 commits March 23, 2016 10:15
A better color generator, with pastel colors and a brightness check to prevent illisible text.
@skjnldsv
Copy link
Contributor Author

@irgendwie Good here?

@DeepDiver1975 DeepDiver1975 merged commit 43c628d into owncloud:master Mar 23, 2016
@skjnldsv skjnldsv deleted the skjnldsv-patch-new-color-generator branch March 23, 2016 10:09
@jancborchardt
Copy link
Member

@skjnldsv can you directly modify the color generator in core please? See https://github.com/owncloud/core/blob/master/core/js/placeholder.js#L54-L58 :)

Because we should use the same color scheme across ownCloud, especially for the placeholders. When I share something with a person, the placeholder should be the same as in the Contacts app for that person.

@skjnldsv
Copy link
Contributor Author

Dammit, why no one said that before? :p

@jancborchardt
Copy link
Member

@skjnldsv yeah, sorry bout that. ;) Would still be cool if you could do that. :)

@skjnldsv
Copy link
Contributor Author

Too busy crying ;)
Will do in a moment, i'm working on the header inputs now.

@jancborchardt
Copy link
Member

:D Welcome to open source development ;D

@skjnldsv
Copy link
Contributor Author

Wait a minute, I didn't realised. You want to use the core generator in the contacts app, or my generator in core?
If you were considering the second option, please see #306

@jancborchardt
Copy link
Member

@skjnldsv a combination of both: Ideally your improvements are done to the core generator, and then we use the core generator in Contacts. (Because the core generator is also used everywhere else.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants