-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better colors generator #261
Better colors generator #261
Conversation
By analyzing the blame information on this pull request, we identified @Henni to be a potential reviewer |
@skjnldsv Would you mind squashing your last commit? (https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/) |
A better color generator, with pastel colors and a brightness check to prevent illisible text.
@irgendwie Good here? |
@skjnldsv can you directly modify the color generator in core please? See https://github.com/owncloud/core/blob/master/core/js/placeholder.js#L54-L58 :) Because we should use the same color scheme across ownCloud, especially for the placeholders. When I share something with a person, the placeholder should be the same as in the Contacts app for that person. |
Dammit, why no one said that before? :p |
@skjnldsv yeah, sorry bout that. ;) Would still be cool if you could do that. :) |
Too busy crying ;) |
:D Welcome to open source development ;D |
Wait a minute, I didn't realised. You want to use the core generator in the contacts app, or my generator in core? |
@skjnldsv a combination of both: Ideally your improvements are done to the core generator, and then we use the core generator in Contacts. (Because the core generator is also used everywhere else.) |
A better color generator, with pastel colors and a brightness check to prevent illisible text.
I didn't liked the colors on the contacts app, so i made a color generator using the hsl wheel and a different angle base on the contact uid. I use a hsl to rgb function found online (too simple to bother coding the same function on my own) and a basic common brightness algorithm.