-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groups from categories in vcards #39
Conversation
@DeepDiver1975 should be fixed now |
The last commit fixes the regression that clicking on a contact changes the gid. |
nice! 👍 |
there is one error I'm observing:
|
3f82be2
to
2e832f7
Compare
rebased |
fixes #38 |
@jancborchardt please review |
Highlighting of the selected group doesn't work on page load. |
basically I need to set the selectedGroup and selectedContactId on url change as well |
fixed |
HTML looks good, only the |
I have no idea where this addressbook is coming from |
Renaming addressBook to group in the following lines should fix it: |
@jancborchardt fixed - I also pushed some changes to have a better empty view experience - not yet done - will work on this in a follow up pr |
Cool, let’s get this in and work on additional things in future PRs. 👍 |
Groups from categories in vcards
@Henni loading of the group via url does not yet fully work