Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups from categories in vcards #39

Merged
merged 12 commits into from
Feb 19, 2016
Merged

Groups from categories in vcards #39

merged 12 commits into from
Feb 19, 2016

Conversation

DeepDiver1975
Copy link
Member

@Henni loading of the group via url does not yet fully work

@DeepDiver1975 DeepDiver1975 added this to the 1.0-current milestone Feb 18, 2016
@Henni
Copy link
Contributor

Henni commented Feb 18, 2016

@DeepDiver1975 should be fixed now

@Henni
Copy link
Contributor

Henni commented Feb 18, 2016

The last commit fixes the regression that clicking on a contact changes the gid.

@DeepDiver1975
Copy link
Member Author

nice! 👍

@DeepDiver1975
Copy link
Member Author

there is one error I'm observing:

Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: group in groups, Duplicate key:

@DeepDiver1975 DeepDiver1975 self-assigned this Feb 18, 2016
@DeepDiver1975
Copy link
Member Author

rebased

@DeepDiver1975
Copy link
Member Author

fixes #38

@DeepDiver1975
Copy link
Member Author

@jancborchardt please review

@Henni
Copy link
Contributor

Henni commented Feb 18, 2016

Highlighting of the selected group doesn't work on page load.
It should be probably based on $routeParams.

@DeepDiver1975
Copy link
Member Author

It should be probably based on $routeParams.

basically I need to set the selectedGroup and selectedContactId on url change as well

@DeepDiver1975
Copy link
Member Author

Highlighting of the selected group doesn't work on page load.

fixed

@jancborchardt
Copy link
Member

HTML looks good, only the templates/group.html having addressBook stuff in it doesn’t fully make sense to me.

@DeepDiver1975
Copy link
Member Author

HTML looks good, only the templates/group.html having addressBook stuff in it doesn’t fully make sense to me.

I have no idea where this addressbook is coming from

@DeepDiver1975
Copy link
Member Author

@jancborchardt fixed - I also pushed some changes to have a better empty view experience - not yet done - will work on this in a follow up pr

@jancborchardt
Copy link
Member

Cool, let’s get this in and work on additional things in future PRs. 👍

jancborchardt added a commit that referenced this pull request Feb 19, 2016
Groups from categories in vcards
@jancborchardt jancborchardt merged commit 216ab7a into master Feb 19, 2016
@jancborchardt jancborchardt deleted the groups-for-exit branch February 19, 2016 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants