Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular.isBoolean is unknown #551

Merged
merged 1 commit into from
Dec 6, 2016
Merged

angular.isBoolean is unknown #551

merged 1 commit into from
Dec 6, 2016

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Dec 6, 2016

@DeepDiver1975 DeepDiver1975 added this to the 1.5.2 milestone Dec 6, 2016
@codecov-io
Copy link

codecov-io commented Dec 6, 2016

Current coverage is 12.57% (diff: 100%)

Merging #551 into master will increase coverage by 0.22%

@@             master       #551   diff @@
==========================================
  Files            46         46          
  Lines           875        875          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            108        110     +2   
+ Misses          767        765     -2   
  Partials          0          0          

Powered by Codecov. Last update 5a8b428...de3d2e2

@DeepDiver1975 DeepDiver1975 merged commit d70cf68 into master Dec 6, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-ng-isBoolean branch December 6, 2016 10:25
@arkascha
Copy link

arkascha commented Dec 6, 2016

Does not work for me.
Installed the linked archive, deleted the assets js file and reloaded the contact apps - still the same issue: an endless spinner instead of a list of contacts. I don't see anything related in the browsers js console. Using oc-9.1.2

@DeepDiver1975
Copy link
Member Author

I don't see anything related in the browsers js console.

so at least the isBoolean issue is gone

@DeepDiver1975
Copy link
Member Author

@arkascha how many addressbooks and how many contacts?

@arkascha
Copy link

arkascha commented Dec 6, 2016

3 address book inside owncloud holding 332 contacts in total.
app version 1.5.0 take a few seconds to load, actually the "no contacts in here" is shown while the spinner is still busy, but then the contacts appear.
I do not see anything relevant in the server side log files.

@DeepDiver1975
Copy link
Member Author

@arkascha was the behavior in 1.4.x the same?

@arkascha
Copy link

arkascha commented Dec 6, 2016

@DeepDiver1975:
Sorry, I just checked since your question confused me and I have to correct my statement from above:
I previously had 1.4 installed, not 1.5. In 1.4.0.0 (which I now reinstalled) all works fine for me.

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975:
Sorry, I just checked since your question confused me and I have to correct my statement from above:
I previously had 1.4 installed, not 1.5. In 1.4.0.0 (which I now reinstalled) all works fine for me.

hmmm - strange ... mind opening a new issue to track this? THX

@arkascha
Copy link

arkascha commented Dec 7, 2016

Done: #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular.isBoolean is not a function
3 participants