No longer show the version number in the public

owncloud · Mar 27, 2017 · 0b02b10 · 0b02b10
1 parent 0fa9553
commit 0b02b10
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/config/config.sample.php b/config/config.sample.php
@@ -79,6 +79,12 @@
  */
 'version' => '',
 
+/**
+ * While hardening an ownCloud instance hiding the version information in status.php
+ * can be a legitim step. Please condult the documentation before enabling this.
+ */
+'version.hide' => false,
+
 /**
  * Identifies the database used with this installation. See also config option
  * ``supportedDatabases``

diff --git a/core/js/config.php b/core/js/config.php
@@ -37,6 +37,11 @@
  *
  */
 
+if (OC_User::getUser() === null) {
+	header('HTTP/1.0 401 Unauthorized');
+	return;
+}
+
 // Set the content type to Javascript
 header("Content-type: text/javascript");
 

diff --git a/lib/private/OCS/CoreCapabilities.php b/lib/private/OCS/CoreCapabilities.php
@@ -24,6 +24,7 @@
 
 use OCP\Capabilities\ICapability;
 use OCP\IConfig;
+use OCP\Util;
 
 /**
  * Class Capabilities
@@ -52,6 +53,7 @@ public function getCapabilities() {
 			'core' => [
 				'pollinterval' => $this->config->getSystemValue('pollinterval', 60),
 				'webdav-root' => $this->config->getSystemValue('webdav-root', 'remote.php/webdav'),
+				'status' => Util::getStatusInfo(),
 			]
 		];
 	}

diff --git a/lib/public/Util.php b/lib/public/Util.php
@@ -722,10 +722,18 @@ public static function getStatusInfo() {
 			'installed'=> $installed ? 'true' : 'false',
 			'maintenance' => $maintenance ? 'true' : 'false',
 			'needsDbUpgrade' => self::needUpgrade() ? 'true' : 'false',
-			'version' => implode('.', self::getVersion()),
-			'versionstring' => \OC_Util::getVersionString(),
-			'edition' => \OC_Util::getEditionString(),
-			'productname' => $defaults->getName()];
+			'version' => '',
+			'versionstring' => '',
+			'edition' => '',
+			'productname' => ''];
+
+		if ((bool) $systemConfig->getValue('version.hide', false) === false) {
+			$values['version'] = implode('.', self::getVersion());
+			$values['versionstring'] = \OC_Util::getVersionString();
+			$values['edition'] = \OC_Util::getEditionString();
+			$values['productname'] = $defaults->getName();
+		}
+
 		return $values;
 	}
 }