Add JS tests for file locking plugin

apps/files/js/locktabview.js

@@ -76,6 +76,9 @@
 			 * Renders this details view
 			 */
 			render: function () {
+				if (!this.model) {
+					return;
+				}
 				this.$el.html(this.template({
 					emptyResultLabel: t('files', 'Resource is not locked'),
 					locks: this.model.get('activeLocks'),

apps/files/tests/js/filelockpluginSpec.js

@@ -0,0 +1,154 @@
+/*
+ * Copyright (c) 2018 Vincent Petry <pvince81@owncloud.com>
+ *
+ * This file is licensed under the Affero General Public License version 3
+ * or later.
+ *
+ * See the COPYING-README file.
+ *
+ */
+
+/* global dav */
+describe('OCA.Files.LockPlugin tests', function() {
+	var fileList;
+	var testFiles;
+	var testLockData;
+	var currentUserStub;
+
+	beforeEach(function() {
+		var $content = $('<div id="content"></div>');
+		$('#testArea').append($content);
+		// dummy file list
+		var $div = $(
+			'<div>' +
+			'<table id="filestable">' +
+			'<thead></thead>' +
+			'<tbody id="fileList"></tbody>' +
+			'</table>' +
+			'</div>');
+		$('#content').append($div);
+
+		currentUserStub = sinon.stub(OC, 'getCurrentUser').returns({uid: 'currentuser'});
+
+		fileList = new OCA.Files.FileList($div);
+		OCA.Files.LockPlugin.attach(fileList);
+
+		testLockData = {
+			lockscope: 'exclusive',
+			locktype: 'write',
+			lockroot: '/owncloud/remote.php/dav/files/currentuser/basepath',
+			depth: 1,
+			timeout: '12345',
+			locktoken: 'tehtoken',
+			owner: 'lock owner'
+		};
+
+		testFiles = [{
+			id: '1',
+			type: 'file',
+			name: 'One.txt',
+			path: '/subdir',
+			mimetype: 'text/plain',
+			size: 12,
+			permissions: OC.PERMISSION_ALL,
+			etag: 'abc',
+			activeLocks: [testLockData]
+		}];
+	});
+	afterEach(function() {
+		fileList.destroy();
+		fileList = null;
+		currentUserStub.restore();
+	});
+
+	describe('Lock data attribute', function() {
+		it('sets active locks attribute', function() {
+			var $tr;
+			fileList.setFiles(testFiles);
+			$tr = fileList.$el.find('tbody tr:first');
+			expect(JSON.parse($tr.attr('data-activeLocks'))).toEqual([testLockData]);
+		});
+	});
+	describe('elementToFile', function() {
+		it('returns lock data', function() {
+			fileList.setFiles(testFiles);
+			var $tr = fileList.findFileEl('One.txt');
+			var data = fileList.elementToFile($tr);
+			expect(data.activeLocks).toEqual([testLockData]);
+		});
+		it('returns empty array when no lock data is present', function() {
+			delete testFiles[0].activeLocks;
+			fileList.setFiles(testFiles);
+			var $tr = fileList.findFileEl('One.txt');
+			var data = fileList.elementToFile($tr);
+			expect(data.activeLocks).toEqual([]);
+		});
+	});
+	describe('parsing lock info from response XML', function() {
+		var requestDeferred;
+		var requestStub;
+		beforeEach(function() {
+			requestDeferred = new $.Deferred();
+			requestStub = sinon.stub(dav.Client.prototype, 'request').returns(requestDeferred.promise());
+		});
+		afterEach(function() { 
+			requestStub.restore(); 
+		});
+
+		it('sends lock property in PROPFIND', function() {
+			expect('TODO').toEqual(true);
+		});
+		it('parses lock information from response XML to JSON', function(done) {
+			var xml =
+				'<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">' +
+				'	<d:response>' +
+				'		<d:href>/owncloud/remote.php/dav/files/currentuser/basepath</d:href>' +
+				'		<d:propstat>' +
+				'			<d:prop>' +
+				'				<oc:permissions>RDNVCK</oc:permissions>' +
+				'			</d:prop>' +
+				'			<d:status>HTTP/1.1 200 OK</d:status>' +
+				'		</d:propstat>' +
+				'   </d:response>' +
+				'	<d:response>' +
+				'		<d:href>/owncloud/remote.php/dav/files/currentuser/basepath/One.txt</d:href>' +
+				'		<d:propstat>' +
+				'			<d:prop>' +
+				'				<oc:permissions>RDNVCK</oc:permissions>' +
+				'				<d:lockdiscovery>' +
+				'					<d:activelock>' +
+				'						<d:lockscope><d:exclusive/></d:lockscope>' +
+				'						<d:locktype><d:write/></d:locktype>' +
+				'						<d:lockroot>' +
+				'							<d:href>/owncloud/remote.php/dav/files/currentuser/basepath</d:href>' +
+				'						</d:lockroot>' +
+				'						<d:depth>1</d:depth>' +
+				'						<d:timeout>12345</d:timeout>' +
+				'						<d:locktoken>' +
+				'							<d:href>tehtoken</d:href>' +
+				'						</d:locktoken>' +
+				'						<d:owner>lock owner</d:owner>' +
+				'					</d:activelock>' +
+				'				</d:lockdiscovery>' +
+				'			</d:prop>' +
+				'			<d:status>HTTP/1.1 200 OK</d:status>' +
+				'		</d:propstat>' +
+				'	</d:response>' +
+				'</d:multistatus>';
+
+			xml = dav.Client.prototype.parseMultiStatus(xml);
+			var promise = fileList.reload();
+			requestDeferred.resolve({
+				status: 207,
+				body: xml
+			});
+
+			promise.then(function(status, response) {
+				var $tr = fileList.findFileEl('One.txt');
+				var data = fileList.elementToFile($tr);
+				expect(data.activeLocks).toEqual([testLockData]);
+				done();
+			});
+		});
+	});
+});