WebUI test check blacklisted group sharing

tests/acceptance/config/behat.yml

@@ -226,6 +226,7 @@ default:
         - WebUIGeneralContext:
         - WebUILoginContext:
         - WebUISharingContext:
+        - WebUIAdminSharingSettingsContext:
 
     webUISharingInternalUsers:
       paths:

tests/acceptance/features/bootstrap/WebUIAdminSharingSettingsContext.php

@@ -216,7 +216,21 @@ public function theAdminRestrictsUsersToOnlyShareWithTheirGroupMemberUsingTheWeb
 			$this->getSession()
 		);
 	}
-
+
+	/**
+	 * @When the administrator adds the group :group to the group sharing blacklist using the webUI
+	 *
+	 * @param string $group
+	 *
+	 * @return void
+	 */
+	public function theAdministratorAddsTheGroupToTheGroupSharingBlacklistUsingTheWebui($group) {
+		$this->adminSharingSettingsPage->addGroupToGroupSharingBlacklist($group);
+		$this->adminSharingSettingsPage->waitForAjaxCallsToStartAndFinish(
+			$this->getSession()
+		);
+	}
+
 	/**
 	 * This will run before EVERY scenario.
 	 * It will set the properties for this object.

tests/acceptance/features/bootstrap/WebUIGeneralContext.php

@@ -640,6 +640,9 @@ public function setUpScenario(BeforeScenarioScope $scope) {
 				);
 			}
 		}
+		SetupHelper::runOcc(
+			['config:app:set files_sharing blacklisted_receiver_groups --value=']
+		);
 	}
 
 	/**
@@ -808,5 +811,8 @@ public function reportResult(AfterScenarioScope $afterScenarioScope) {
 		} else {
 			\error_log("SCENARIO RESULT: ($passOrFail)");
 		}
+		SetupHelper::runOcc(
+			["config:app:set files_sharing blacklisted_receiver_groups --value"]
+		);
 	}
 }

tests/acceptance/features/lib/AdminSharingSettingsPage.php

@@ -59,6 +59,10 @@ class AdminSharingSettingsPage extends OwncloudPage {
 	protected $onlyShareWithGroupMembersCheckboxXpath = '//label[@for="onlyShareWithGroupMembers"]';
 	protected $onlyShareWithGroupMembersCheckboxId = 'onlyShareWithGroupMembers';
 
+	protected $groupSharingBlackListFieldXpath = '//div[@id="files_sharing"]//input[contains(@class,"select2-input")]';
+	protected $groupListXpath = '//div[@id="select2-drop"]//li[contains(@class, "select2-result")]';
+	protected $groupListDropDownXpath = "//div[@id='select2-drop']";
+
 	/**
 	 * toggle checkbox
 	 *
@@ -265,6 +269,40 @@ public function toggleRestrictUsersToOnlyShareWithTheirGroupMembers($action) {
 		);
 	}
 
+	/**
+	 * add group to group sharing blacklist
+	 *
+	 * @param string $groupName
+	 *
+	 * @return void
+	 */
+	public function addGroupToGroupSharingBlacklist($groupName) {
+		$groupSharingBlackListField = $this->find("xpath", $this->groupSharingBlackListFieldXpath);
+		if ($groupSharingBlackListField === null) {
+			throw new ElementNotFoundException(
+				__METHOD__ .
+				" xpath $this->groupSharingBlackListFieldXpath " .
+				"could not input field"
+			);
+		}
+		$groupSharingBlackListField->click();
+		$this->waitTillElementIsNotNull($this->groupListDropDownXpath);
+		$this->waitTillElementIsNotNull($this->groupListXpath);
+		$groupList = $this->findAll("xpath", $this->groupListXpath);
+		if ($groupSharingBlackListField === null) {
+			throw new ElementNotFoundException(
+				__METHOD__ .
+				" xpath $this->groupListXpath " .
+				"could not find group list"
+			);
+		}
+		foreach ($groupList as $group) {
+			if ($this->getTrimmedText($group) === $groupName) {
+				$group->click();
+			}
+		}
+	}
+
 	/**
 	 * waits till at least one Ajax call is active and
 	 * then waits till all outstanding ajax calls finish

tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature

@@ -15,11 +15,11 @@ Feature: Sharing files and folders with internal groups
       | grp1      |
     And user "user1" has been added to group "grp1"
     And user "user2" has been added to group "grp1"
-    And user "user3" has logged in using the webUI
 
   @TestAlsoOnExternalUserBackend
   @smokeTest
   Scenario: share a folder with an internal group
+    Given user "user3" has logged in using the webUI
     When the user shares the folder "simple-folder" with the group "grp1" using the webUI
     And the user shares the file "testimage.jpg" with the group "grp1" using the webUI
     And the user re-logs in as "user1" using the webUI
@@ -35,6 +35,7 @@ Feature: Sharing files and folders with internal groups
 
   @TestAlsoOnExternalUserBackend
   Scenario: share a file with an internal group a member overwrites and unshares the file
+    Given user "user3" has logged in using the webUI
     When the user renames the file "lorem.txt" to "new-lorem.txt" using the webUI
     And the user shares the file "new-lorem.txt" with the group "grp1" using the webUI
     And the user re-logs in as "user1" using the webUI
@@ -55,6 +56,7 @@ Feature: Sharing files and folders with internal groups
 
   @TestAlsoOnExternalUserBackend
   Scenario: share a folder with an internal group and a member uploads, overwrites and deletes files
+    Given user "user3" has logged in using the webUI
     When the user renames the folder "simple-folder" to "new-simple-folder" using the webUI
     And the user shares the folder "new-simple-folder" with the group "grp1" using the webUI
     And the user re-logs in as "user1" using the webUI
@@ -86,6 +88,7 @@ Feature: Sharing files and folders with internal groups
   @TestAlsoOnExternalUserBackend
   @smokeTest
   Scenario: share a folder with an internal group and a member unshares the folder
+    Given user "user3" has logged in using the webUI
     When the user renames the folder "simple-folder" to "new-simple-folder" using the webUI
     And the user shares the folder "new-simple-folder" with the group "grp1" using the webUI
 		# unshare the received shared folder and check it is gone
@@ -104,3 +107,13 @@ Feature: Sharing files and folders with internal groups
     When the user opens the folder "new-simple-folder" using the webUI
     Then the file "lorem.txt" should be listed on the webUI
     And the content of "lorem.txt" should be the same as the original "simple-folder/lorem.txt"
+
+  Scenario: user tries to share a file in a group which is blacklisted from sharing
+    Given the administrator has browsed to the admin sharing settings page
+    When the administrator adds the group "grp1" to the group sharing blacklist using the webUI
+    Then user "user3" should not be able to share folder "lorem.txt" with group "grp1" using the sharing API
+
+  Scenario: user tries to share a folder in a group which is blacklisted from sharing
+    Given the administrator has browsed to the admin sharing settings page
+    When the administrator adds the group "grp1" to the group sharing blacklist using the webUI
+    Then user "user3" should not be able to share folder "simple-folder" with group "grp1" using the sharing API