Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send password when sharing via e-mail #11682

Closed
enoch85 opened this issue Oct 21, 2014 · 42 comments
Closed

Send password when sharing via e-mail #11682

enoch85 opened this issue Oct 21, 2014 · 42 comments

Comments

@enoch85
Copy link
Member

enoch85 commented Oct 21, 2014

Instead of having to send the password in a seperate email we should do it automatically by adding an additional send button that says "Send with password" next to the regular "Send" button in those cases when you add a password to a link and decides to send the shared link per email.

In the e-mail the user gets it should say something like;
"The link is password protected. The password is: [Password]"

What do you think @jancborchardt @LukasReschke ?

@LukasReschke
Copy link
Member

This depends on how we advertise the functionality and what the main use-case behind this is.

Currently, it's implemented as kind of a two-factor authentication, there is something you know (the password) and something you have (the link). If we would send the password via the email the two-factor authentication would have gone in the background, in this case the password would only protect you in case you find the link in the history or have guessed it, or it was on a website listed etc...

So actually, both use-cases are absolutely okay as long as we communicate such changes appropriately to our end-users. There is nothing worse than giving the user a wrong expectation of security, which in this case could easily happen if we change the default behaviour.

Therefore I'd advocate that we let this choice to the user and should invest time to implement a mail editor such as Dropbox has or add at least a checkbox ("Send password") to the sharing overview. There are so many possible use-cases for this functionality and we should try hard to make all our users happy :-)

@MTRichards @karlitschek What do you think?

@enoch85
Copy link
Member Author

enoch85 commented Oct 21, 2014

@LukasReschke

implement a mail editor such as Dropbox has or add at least a checkbox ("Send password") to the sharing overview

Now we´re talking! Even better suggestion than I had thought of. I think both and mail editor, and a checkbox "Send password" would be two major improvements.

@jancborchardt
Copy link
Member

Yes, a checkbox would be the right choice here (unchecked by default). And a mail editor would be good as well so it’s more personal.

@enoch85
Copy link
Member Author

enoch85 commented Nov 7, 2014

@jancborchardt Agree. :)

@MTRichards
Copy link
Contributor

Therefore I'd advocate that we let this choice to the user and should invest time to implement a mail editor such as Dropbox has or add at least a checkbox ("Send password") to the sharing overview. There are so many possible use-cases for this functionality and we should try hard to make all our users happy :-)

I like it!

@enoch85
Copy link
Member Author

enoch85 commented Dec 9, 2014

This could be used when sending passwords to users aswell. #12603

@enoch85
Copy link
Member Author

enoch85 commented Mar 23, 2015

Ping @jancborchardt @LukasReschke @MTRichards Any milestone for this?

@rullzer
Copy link
Contributor

rullzer commented Mar 23, 2015

I assume this should also be added in the new sharing modal: #5873

@cycloon
Copy link

cycloon commented Mar 23, 2015

Instead of sending plain text passwords you could send only username and an activation link. That activation link could then behave like the current password reset.

That way you never have to send a password over untrusted connections (read: email) and you even reach a second goal: the user is forced to choose a password on his own.

@enoch85
Copy link
Member Author

enoch85 commented Mar 23, 2015

@cycloon That would be perfect!

@rullzer
Copy link
Contributor

rullzer commented Mar 24, 2015

@cycloon while that would be possible it does require a significant amount of changes. Since currently we have at most 1 share per link. Which you can share and e-mail with a ton of people. In this scenario you can only share with 1 person by link.

Probably some discussion is required if that is the desired way to go.

@jancborchardt
Copy link
Member

@rullzer maybe related, from the design forward of the sharing dialog:

future: generate unique link per email address so revocation on a per-person basis is possible

@Froster
Copy link

Froster commented Apr 9, 2015

Hi

but what is if the User should become the shared e-mail is not a know user in the system? So it should be possible only to activate the option "send password with email". for everyone share via mail.

@jancborchardt
Copy link
Member

@Froster they will get a personalized share link, as we said above. The password is a different topic – all the links will be separate so if you deactivate a person’s link they can not view it anymore.

@Froster
Copy link

Froster commented Apr 10, 2015

@jancborchardt yeah you are right but as you see my request was closed and i was linked here.

  • for personal links it should be able for the user to monitore them on a seperated page maybe in an app in the WebUI so the he could overview them to reduce complexity
  • even i don't know if the hole System with personal links could be to complex in business proposes if you have mainly normal users
  • and i wonder that "Nobody" here think about how to manage this via mobile app this should be the same workflow as in web

I know the hole discuss about Password.This is my request:

share context Menu
•if password is set (or is newly set or changed)
•option checkbox should appear
•variable available in the email template ##email##

@jancborchardt jancborchardt added this to the backlog milestone May 1, 2015
@kylesouza
Copy link

Hello! sorry for my ignorance, how am I able to see the progress of features such as this one? Would this be the best place to look?

@jancborchardt
Copy link
Member

@kylesouza yes. And as you see the issue is in the backlog. That means it’s not scheduled for any release specifically, and there’s currently no work being done on it.

@kylesouza
Copy link

Okay, thanks! I'm very new to github and open source and such.

On Sat, Jun 20, 2015 at 4:07 AM -0700, "Jan-Christoph Borchardt" notifications@github.com wrote:
@kylesouza yes. And as you see the issue is in the backlog. That means it’s not scheduled for any release specifically, and there’s currently no work being done on it.


Reply to this email directly or view it on GitHub:
#11682 (comment)

@enoch85
Copy link
Member Author

enoch85 commented Jul 6, 2015

Ref: #17398

@ghost
Copy link

ghost commented Jul 6, 2015

I think #17398 is unrelated as this is a completely different use-case. When sharing a link password protected it makes no sense to send out a link where a user can set its own password for the share.

@sysgloo
Copy link

sysgloo commented Jul 9, 2015

We will wait for the solution of features! thx'

@enoch85
Copy link
Member Author

enoch85 commented Jan 6, 2016

@MTRichards @bboule So this will be in 9.1?

@MTRichards
Copy link
Contributor

Possibly. It is in the backlog for evaluation when we get to 9.1 planning, then we will know for certain.

@BornToBeRoot
Copy link

Send Password would be great. But how about security?
Maybe send the password in a second mail?

@michaelstingl
Copy link

@MTRichards Is the milestone still correct?

@MTRichards
Copy link
Contributor

Nope, milestone is not correct.

And there are problems with sending the password as @BornToBeRoot pointed out. No point in sending the password in the same email. Maybe a second email works, but we also need to remember the system doesn't store the password, it stores the hash of the password - so after the initial setup, if you don't remember the password, we can't send it again the next time you visit the link.

@MTRichards
Copy link
Contributor

If you want this feature, feel free to add it to the overall planning list and vote it up!
#24684

@MTRichards MTRichards modified the milestones: backlog, 9.1-current May 25, 2016
@enoch85
Copy link
Member Author

enoch85 commented May 25, 2016

Done: #24684 (comment)

@hodyroff
Copy link
Contributor

Second email is a good start. Password via SMS or any other user defined channel for sending it would be better. Meaning: As a user I would want to decide if such PW goes out by SMS, or maybe per Signal message. Seems like I would first need to select the route and then type the password due to the storing as hash nature.

@UU0113
Copy link

UU0113 commented Aug 4, 2016

I totally agrree to this function. Owncloud should give this option to include the password as well. I understand the security risks but this is something Owncloud should note taking care of. The default option is to disable this but a checkbox should allow to include the password (maybe with a hint that emails might be read by someone else). Many companies now using mail gateways and encrypt e-mail with S/MIME or PGP. Don't you?

Long story short: The user may decide how to handle the password, not Owncloud developers view on.

Just remember, you have to build software that is 'easy' to use for non-technical people. Those people just don't care about your security concerns and suggestions ("oh please use another channel for secuirty like SMS") but want share stuff easily. In a real world people just send another mail with the password and complain to IT dept. for this additional steps dropping their productivity for no benefit...

@arjanterheegde
Copy link

Still waiting for this function.

@dnviti
Copy link

dnviti commented Jun 29, 2017

Hi we also need this function, please re open this post.
I'd like to choose if send the password along with the link or not.

@michaelstingl
Copy link

Issue is open and feature is on the product backlog. PR welcome!

@dnviti
Copy link

dnviti commented Jun 29, 2017

Thank you!

@enoch85
Copy link
Member Author

enoch85 commented Jun 29, 2017

This feature was introduced in Nextcloud 12. So for me this is already fixed since I migrated.

@happicamper
Copy link

Will wait for this feature! Thanks in advance. 🎆

@PVince81
Copy link
Contributor

What we can do is add a placeholder for the password but not include it in the default template. So if people really want this security risk they need to edit the template to add the placeholder name into their template.

cc @pmaier1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests