Migration disable all apps

[eMerzh]

I was using OC5 alpha1 (from yesterday's git master)...
today i pull the changes to the new beta and i got the message about the upgrade.... all good ...
but i also got the message about the disabled apps because of incompatibilities ...

All my apps got disabled ....

{"app":"core","message":"App \"Files\" (files) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389479}
{"app":"core","message":"App \"Calendar\" (calendar) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389479}
{"app":"core","message":"App \"Contacts\" (contacts) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389479}
{"app":"core","message":"App \"Image Viewer\" (files_imageviewer) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}
{"app":"core","message":"App \"Pictures\" (gallery) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}
{"app":"core","message":"App \"Share Files\" (files_sharing) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}
{"app":"core","message":"App \"Bookmarks\" (bookmarks) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}
{"app":"core","message":"App \"News\" (news) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}
{"app":"core","message":"App \"Notes\" (notes) can't be used because it is not compatible with this version of ownCloud","level":3,"time":1361389480}

all those app are compatible with this version so they shouldn't be disabled...
i got all of them back after going in admin enabling all the apps.

debian stable,
apache,
firefox

[VicDeo]

yep, it's probably worth to wipe cached app data after entering the maintenance mode

[karlitschek]

Might be a problem in the info.xmls of the apps

[eMerzh]

@karlitschek i don't see anything special...
the require is like 4.91 for nearly all app

[karlitschek]

Yep. The beta 1 is 4.92. I think we have to fix all the version numbers in all apps

[BernhardPosselt]

ill take care of this next week unless someone spots the problem and quickfixes it earlier :)

[eMerzh]

The require thing isn't a "minimum" required version?
like i need at least OC4 (if OC5 then ok)

isn't the problem about https://github.com/owncloud/core/blob/master/lib/app.php#L854 here ? ( check also https://github.com/owncloud/core/blob/master/lib/app.php#L226 )
for the install we only check the first digit and for the update we check 2 ...

and i don't really understand the sign ... shouldn't we check float instead of strings (and in the other way arround)

i mean :

(  (float) ($version[0].'.'.$version[1]) > (float) $info['require'] )

// instead of 
 (($version[0].'.'.$version[1])>$info['require'])

?

(and shouldn't we put the same check for install AND upgrade?)

[BernhardPosselt]

i think PHP automatically converts string to floats in this comparison, not sure though

[VicDeo]

@eMerzh it's even more simple http://php.net/manual/en/function.version-compare.php

[eMerzh]

ok then what about

    if(!isset($info['require']) or ( version_compare(implode('.',$version), $info['require'], '<'  ) {
       //THEN ERRRRRR

[VicDeo]

@Raydiation no, they are compared as strings character by character without any casting. In general that's enough if both have the same length for every digit field and only digits inside:
4.90.2 > 4.90.1 is true

[VicDeo]

@eMerzh I've tried to replace the conditions at https://github.com/owncloud/core/blob/master/lib/app.php#L854
It doesn't help.
xDebug definitely knows more, I'll try to ask him if I have some spare hours this weekend 😄

[BernhardPosselt]

Could someone check if this is ok with #1888

[eMerzh]

Yep, thanks for the fix, it work fine for me