display version number for disabled apps with occ app:list

[dercorn]

All operating systems, all oc versions.

occ app:list shows version numbers only for enabled apps. Please make version numbers also visible for disabled apps.

[ownclouders]

GitMate.io thinks possibly related issues are #28085 (can't disable app with occ command), #1805 (Migration disable all apps ), #18690 ("Enable only for specific groups" of App shows it disabled in occ app:list), #14661 (Provide app version in occ app:list), and #16806 (Update disables apps).

[VicDeo]

Tricky questions:

1. If the app was enabled a while ago, disabled and update there are two versions: the version in DB and the version from appinfo.xml. When these versions differ app upgrade will triggered after enabling the app. Which one is expected to be listed when they differ?

2. The app files were deleted by admin without disabling it, it still has a version in DB but appinfo.xml is missing. What is expected to be listed?

[pmaier1]

Please make version numbers also visible for disabled apps.

Is there a specific reason for this?!

Which one is expected to be listed when they differ?

I'd say the database state as this is the state oC "actually knows".

What is expected to be listed?

Same, the database state.

Is there a reason why this differs between enabled and disabled in the first place?

[pako81]

Should the app:list command get the version for disabled apps from DB (means apps that have been once enabled and then disabled) or also get this information for disabled apps which have been never enabled from info.xml? Since in the latter case, there is no installed_version in oc_appconfig.

[pako81]

To be more clear: do we need to also consider the case of apps which have been never enabled? If not, the change would be quite easy to implement.

[phil-davis]

And the 2 versions might be different. e.g. an app was enabled, v1.0. The sysadmin has disabled the app. An updated app has been put into the apps folder, but not yet enabled.

And the app might be in multiple folders in apps_paths and have different versions (not recommended, but can happen).

I guess stage 1 would be to display the version of the app that would be active if you enabled the app "right now".

[pako81]

@phil-davis yes, absolutely valid points. But I guess we should only gather this information from the DB regardless if filesystem contains different app versions in info.xml. Because DB is the "source of truth", means that is the app version known to oC at that point in time.

Is this what you mean with "I guess stage 1 would be to display the version of the app that would be active if you enabled the app "right now"?

[phil-davis]

Is this what you mean with "I guess stage 1 would be to display the version of the app that would be active if you enabled the app "right now"?

I suspect that if you have a new version of the app code in apps_paths somewhere, then when you enable the app, the version recorded in the database will be automagically updated. If that is true, then the DB is only the "source of truth" about the version that was in use the last time the app was enabled.

Take your pick for what to display - it depends what question the sysadmin wants answered!

[pako81]

I suspect that if you have a new version of the app code in apps_paths somewhere, then when you enable the app, the version recorded in the database will be automagically updated.

Correct. But not automagically. You are required to run occ upgrade

[pako81]

Very straightforward approach proposed in #36165

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.