showDropDown broken, should use ShareDialogView

[PVince81]

@blizzz can you take care of this ?

It should be a matter of opening the dropdown and embedding the new ShareDialogView into it.
It seems it doesn't work any more.

CC @oparoz

[PVince81]

The gallery app needs this

[karlitschek]

Yes. This is critical

[blizzz]

After investigating, some apps (at least Gallery :D) were using the old share dialog and manipulating it. Best and safest way for 8.2 seems to pack the "old" share dialog code into one file, let it both ship and load by the apps who need it. For 9.0 we look into a way to satisfy the needs of gallery, calendar and such by providing possibilities to interact with the new share dialogue code in a sane way (real API :D).

[PVince81]

I'm looking into providing a portable namespaced "share.js" that can be copied into gallery, calendar and contacts and usable directly.

[PVince81]

• calendar: Bump gulp-wrap from 0.13.0 to 0.14.0 in /js calendar#940
• contacts: https://github.com/owncloud/contacts/pull/1057
• gallery: Import legacy share dialog code gallery#367
• documents: [master] Sharing dialog is broken after right bar is merged owncloud-archive/documents#550

[PVince81]

I tried putting these additions into the gallery app and it worked.
But the checkboxes are broken (the new styles), so let's wait for @Henni to fix them in owncloud/calendar#940 first.

[PVince81]

PRs are available now for calendar, contacts and gallery: #19214 (comment)

Please review them!

[VicDeo]

Related to owncloud-archive/documents#550

[PVince81]

All known apps have been fixed => closing