Can not wrap storage of owner anymore

[nickvergessen]

Since some day in the last week, I can not wrap non-shared-storages anymore.

Steps to reproduce

1. As user1 create folder test1/test2/
2. Share test2 with user2
3. Tag test1 with "Tag"
4. Create a workflow autotagging rule to tag files with "Tag" when a parent is tagged with "Tag"
5. As user2 upload a file
6. Check that the file is tagged

Expected behaviour

Tag is added

Actual behaviour

Tag is not added

Debugging

It works when you check out cdcabbd which is the last merge commit before: #23919

So I checked the storages and it looks like the sourceStorage inside the SharedStorage is created without being wrapped. I also checked with @schiesbn sitting next to me and there was never a try to wrap that storage.

Please help @rullzer @icewind1991

[rullzer]

I did not try with the workflow app yet. But probabaly it goes wrong in https://github.com/owncloud/core/blob/master/apps/files_sharing/lib/sharedstorage.php#L84

Because that is where we get the storage that the jail wraps...

[rullzer]

When running a debug session... I do see the storage wrapper. But things go wrong when we try to run the plugin. This happens because the wrong cache is probabaly fetched there... I'll look into a bit more detail tomorrow.

[rullzer]

Could you try again with master.
I rebased this morning and it is working...

[rullzer]

Mmm so it seems the tag is not set using the webUI but when doing the PUT via webdav all works fine...

[rullzer]

PR in #24280

[icewind1991]

@nickvergessen try not applying the storage wrapper in app.php directly but instead in the filesystem preSetup

[nickvergessen]

Right, that fixes the issue on plain master. So we should make sure that all apps use that instead of registering in plain app.php?

[icewind1991]

Afaik all (our own) apps do it like that

[nickvergessen]

Well all our EE apps don't :P

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.