Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Disconnect" application password should kill its open sessions #28553

Closed
SamuAlfageme opened this issue Aug 1, 2017 · 10 comments · Fixed by #29533
Closed

"Disconnect" application password should kill its open sessions #28553

SamuAlfageme opened this issue Aug 1, 2017 · 10 comments · Fixed by #29533
Assignees

Comments

@SamuAlfageme
Copy link

SamuAlfageme commented Aug 1, 2017

Directly related to #27845

Steps to reproduce

  1. Create an application password and use it to login in a Desktop/Mobile client
  2. Click on "Disconnect" the application

Expected behavior

  • The same behavior as it happens with the webUI:
  • The same effect as revoking an OAuth2 application authorized on https://<server>/index.php/settings/personal?sectionid=security#oauth-2.0: the clients re-asks for authorization (credentials, in this case) again.

Actual behavior

The session tokens are still valid even when they don't appear listed in authtoken in the DB (where are these stored then?) and the Desktop client is able to use them for syncing until the client is restarted (when it uses the password stored in the keychain to re-authenticate and fails)

@DeepDiver1975 DeepDiver1975 added this to the triage milestone Aug 1, 2017
@DeepDiver1975
Copy link
Member

@Peter-Prochaska something for you I guess ;-)

@SamuAlfageme
Copy link
Author

SamuAlfageme commented Sep 1, 2017

Resolved in #28879

@PVince81
Copy link
Contributor

I've observed this yesterday on 10.0.5 final.

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@individual-it
Copy link
Member

in 10.0.8RC1 the sessions of the client are listed now, but even "disconnecting" them does not end the session of the client. Next time the client syncs a new session is established
delete-session

@phil-davis
Copy link
Contributor

I guess that is expected behavior? When the client syncs again it will provide valid authentication (it knows the username/password for the account on the server). And so the server will establish a session for it, just as if it is the first time that it connected.

To stop that, the sequence would need to be:

  1. Change password on the server
  2. Delete existing session/s

The the next connect from the client will have an invalid password.

@individual-it
Copy link
Member

as I've deleted the app password the client cannot provide any valid authentication anymore

@butonic
Copy link
Member

butonic commented Apr 13, 2018

yeah, known issue I would say. same happens for oauth based sessions. you have to delete the app password or oauth token to prevent sessions from reviving.

@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants