-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sessions of Desktop, iOS and Android clients should be shown #27845
Comments
👍 |
@PVince81 FYI |
I'm using an app specific password for mobile so the "most recent activity" is updated correctly under that session. I don't see any additional entries for this in the first section. Interestingly I also see that the first section header says "Browser". Was it designed to only detect browsers and not mobile clients ? Not sure. Does it work differently in 9.1 ? (might be able to bisect) |
For example in 9.1.6 iOS session appears but not in oCX About the header "browser" it was comment long time ago but it was not changed, I could not find the comment related to change browser as header in GH |
auth / token stuff, @phisch can you have a look ? If not, let me know |
bisect might be possible if this worked in 9.1 |
@PVince81 I can confirm listing the sessions used to work in 9.1 (tested in 9.1.3 and I used to get even cURL logins in the sessions table) - not revoking them though, maybe on a previous version the "Disconnect" button also worked for that. I'd say increase severity here. There's some implications, specially in terms of revoking those sessions now that we're trying to get OAuth2 out of the oven and this might be important to get fixed. EDIT: I can't actually make #24703 to work even in 9.1.0 This is also one of the causes behind #28553. |
@IljaN please bisect this and fix if possible |
|
There was a bug in my bisect script new potential candidate is f1dc2d9, need to analyze |
Confirmed that f1dc2d9 is the offending commit by reintroducing the removed line |
Current token must be not null Generate auth token for http_basic_auth logins Cleanup
Current token must be not null Generate auth token for http_basic_auth logins Cleanup
Current token must be not null Generate auth token for http_basic_auth logins Cleanup
Current token must be not null Generate auth token for http_basic_auth logins Cleanup (cherry picked from commit 03b0bdb)
fixed through #28879 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps to reproduce
Expected behaviour
The User agents from the sessions of Desktop, iOS and Android clients should be shown
Actual behaviour
The User agents from Desktop, iOS and Android clients are not been shown
Server configuration
Operating system:
Ubuntu 16.04
Web server:
Apache
Database:
MySQL
PHP version:
7.0
ownCloud version:
"version":"10.0.0.1" daily master
Updated from an older ownCloud or fresh install:
Fresh
Are you using external storage, if yes which one: local/smb/sftp/...
No
Are you using encryption:
No
Logs
Client configuration
browser
Desktop Client, iOS, Android
It is shown only the ones related to browsers.
The text was updated successfully, but these errors were encountered: