Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API/Acceptance tests for Async Upload #32580

Closed
5 tasks done
patrickjahns opened this issue Sep 4, 2018 · 7 comments
Closed
5 tasks done

API/Acceptance tests for Async Upload #32580

patrickjahns opened this issue Sep 4, 2018 · 7 comments
Assignees
Labels

Comments

@patrickjahns
Copy link
Contributor

patrickjahns commented Sep 4, 2018

With #32414 merged, we are looking to have simple API acceptance tests, that generally test this behavior.

Once these are working, we should consider also using these test steps for:

Double checking for

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @phil-davis.

Possibly related issues are #22492 (test), #31579 (test), #22485 (test), #30493 (Rename integration API tests to acceptance), and #32559 (acceptance tests - stop uploading when receiving an error).

@individual-it individual-it self-assigned this Sep 5, 2018
@individual-it
Copy link
Member

@DeepDiver1975 @PVince81 in the case of an error e.g. MOVE a file that does not exist, the async operation still replies with an 202 code. There is a correct error code in OC-JobStatus-Location, but the request itself returns 202. Is that correct?

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2018

I think I'd rather expect a 404 and have an existence check happen before the job goes async.

@individual-it
Copy link
Member

@PVince81 issue opened here #32598

@individual-it
Copy link
Member

individual-it commented Sep 6, 2018

other interesting tests:

@individual-it
Copy link
Member

moving to next sprint for the rest of the work

@individual-it
Copy link
Member

all done, closing

@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants