Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test file_versions with chunking upload #33743

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Test file_versions with chunking upload #33743

merged 1 commit into from
Dec 4, 2018

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Dec 4, 2018 •
edited
Loading

Description

various tests for file_versions in combination with chunking upload
some small fixes to the test code were needed because file_versions (list & restore) only work with the new webdav path

Related Issue

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it self-assigned this Dec 4, 2018
@individual-it individual-it mentioned this pull request Dec 4, 2018
Closed
5 tasks
@skshetry skshetry changed the title test file_versions witch chunking upload Test file_versions with chunking upload Dec 4, 2018
phil-davis
phil-davis reviewed Dec 4, 2018
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The element-elements thing can be sorted out.

The other comment can be made a separate issue, if you like, or you can try writing a single step now or...

tests/acceptance/features/apiMain/fileVersions.feature
@@ -12,13 +12,39 @@ Feature: dav-versions
When user "user0" uploads file "filesForUpload/davtest.txt" to "/davtest.txt" using the WebDAV API
Then the version folder of file "/davtest.txt" for user "user0" should contain "0" elements

Scenario: Upload file and no version is available using various chunking methods
When user "user0" uploads file "filesForUpload/davtest.txt" to "/davtest.txt" with all mechanisms using the WebDAV API
Then the version folder of file "/davtest.txt-olddav-regular" for user "user0" should contain "0" elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK for now. But it makes the scenario steps have knowledge of the particular way with all mechanisms uploading is implemented in the underlying code. Ideally there could be an equivalent Then step for checking something common about the with all mechanisms files that were uploaded. That step would know how to construct the relevant (4) file names...

tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/WebDav.php Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiMain/fileVersions.feature Outdated Show resolved Hide resolved
@individual-it individual-it force-pushed the fileVersionsChunkUpload branch from 7399f4d to 7d5395f Compare December 4, 2018 13:49
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #33743 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33743      +/-   ##
============================================
- Coverage     64.35%   64.35%   -0.01%     
+ Complexity    18308    18307       -1     
============================================
  Files          1195     1195              
  Lines         69245    69240       -5     
  Branches       1276     1276              
============================================
- Hits          44565    44560       -5     
  Misses        24308    24308              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.67% <ø> (-0.01%) 18307 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...files_sharing/lib/Controller/ShareesController.php 89.15% <0%> (-0.18%) 104% <0%> (-1%)
lib/private/User/Session.php 79.47% <0%> (-0.05%) 154% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454de0d...7d5395f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #33743 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33743      +/-   ##
============================================
- Coverage     64.35%   64.35%   -0.01%     
+ Complexity    18308    18307       -1     
============================================
  Files          1195     1195              
  Lines         69245    69240       -5     
  Branches       1276     1276              
============================================
- Hits          44565    44560       -5     
  Misses        24308    24308              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.67% <ø> (-0.01%) 18307 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...files_sharing/lib/Controller/ShareesController.php 89.15% <0%> (-0.18%) 104% <0%> (-1%)
lib/private/User/Session.php 79.47% <0%> (-0.05%) 154% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454de0d...7d5395f. Read the comment docs.

@individual-it
Copy link
Member Author

@phil-davis addressed comments, please review again

@individual-it individual-it mentioned this pull request Dec 4, 2018
Merged
@individual-it
Copy link
Member Author

backport in #33758

@PVince81 PVince81 merged commit 2c554e0 into master Dec 4, 2018
@delete-merged-branch delete-merged-branch bot deleted the fileVersionsChunkUpload branch December 4, 2018 15:52
@PVince81 PVince81 mentioned this pull request Dec 6, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@paurakhsharma paurakhsharma Awaiting requested review from paurakhsharma

@skshetry skshetry Awaiting requested review from skshetry

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@individual-it individual-it

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API/Acceptance test for chunked upload for file_versioning
3 participants
@individual-it @phil-davis @PVince81