Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API acceptance tests - do not only check hard-coded mime type #32702

Closed
individual-it opened this issue Sep 14, 2018 · 1 comment · Fixed by #34087
Closed

API acceptance tests - do not only check hard-coded mime type #32702

individual-it opened this issue Sep 14, 2018 · 1 comment · Fixed by #34087

Comments

@individual-it
Copy link
Member

in Sharing.php several methods check the mime type of a downloaded file checkLastPublicSharedFileDownload() , checkLastPublicSharedFileWithPasswordDownload() ,theUserShouldBeAbleToDownloadTheFileUsingTheSharingApi()
but "text/plain" is hardcoded as mime-type
make that more flexible to be able to check also other mime-types

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22492 (test), #22485 (test), #31579 (test), #32040 (fix acceptance tests), and #31516 (Acceptance test coding standard changes).

@phil-davis phil-davis changed the title acceptance tests - do not only check hard-coded mime type API acceptance tests - do not only check hard-coded mime type Sep 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants