Remove Hardcoded MimeTypes from the sharing functions #34087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpakach
requested review from
phil-davis,
individual-it,
skshetry and
paurakhsharma
phil-davis
reviewed
Jan 9, 2019
| @@ -394,7 +394,8 @@ public function checkLastPublicSharedFileDownload() { | |||
| $url = $this->lastShareData->data->url; | |||
| } | |||
| $fullUrl = "$url/download"; | |||
| $this->checkDownload($fullUrl, null, null, 'text/plain'); | |||
| $mimeType = \json_decode(\json_encode($this->lastShareData->data->mimetype), 1)[0]; | |||
There was a problem hiding this comment.
We could put this "magic" into a method with a name like getMimeTypeOfLastShare
dpakach
force-pushed
the
remove-hardcoded-mimetypes
branch
from
6a41000
to
9b901a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #34087 +/- ##
============================================
+ Coverage 64.76% 64.77% +<.01%
Complexity 18345 18345
============================================
Files 1198 1198
Lines 69425 69425
Branches 1276 1276
============================================
+ Hits 44965 44969 +4
+ Misses 24091 24087 -4
Partials 369 369
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34087 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18345 18345
=========================================
Files 1198 1198
Lines 69425 69425
Branches 1276 1276
=========================================
Hits 44969 44969
Misses 24087 24087
Partials 369 369
Continue to review full report at Codecov.
|
dpakach
force-pushed
the
remove-hardcoded-mimetypes
branch
from
9b901a1
to
03b8e10
Compare
phil-davis
approved these changes
Jan 9, 2019
|
Backport on #34095 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Sharing functions the last shared file's mimeType were checked with hardcoded
text/plainwhich was not very flexible for sharing files other than text.Removed that to check mimeType from last Shared data.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: