Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review acceptance test "sends HTTP method" steps #33364

Closed
phil-davis opened this issue Oct 31, 2018 · 3 comments
Closed

Review acceptance test "sends HTTP method" steps #33364

phil-davis opened this issue Oct 31, 2018 · 3 comments

Comments

@phil-davis
Copy link
Contributor

In a lot of places in the acceptance tests there are steps that use the general form:

When user "userxyz" sends HTTP method "POST" to OCS API endpoint "/endpoint/something" with body

For example:

When user "brand-new-user" sends HTTP method "POST" to OCS API endpoint "/cloud/groups" with body
      | groupid | new-group |

In this example, the knowledge about the /cloud/groups endpoint is repeated in lots of test scenarios.

Replace these with specific functional steps, like:

When user "userxyz" creates group "new-group"

and let the functional step have the knowledge about the gory detail of the endpoint and how to access it.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22492 (test), #22485 (test), #31579 (test), #32379 (Make more acceptance test methods public), and #31516 (Acceptance test coding standard changes).

@phil-davis
Copy link
Contributor Author

master PR approved and merged. Needs backport.

@phil-davis
Copy link
Contributor Author

Backport #33721 done and merged

@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants