Refactor sends HTTP method to use specific methods #33676

paurakhsharma · 2018-11-28T06:39:31Z

Description

Refactor behat setps like user sends HTTP method 'PUT' to endpoint '/cloud/xyz' to more specific methods, hiding endpoints from behat steps definitions.

Related issue: #33364

How Has This Been Tested?

Locally

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Acceptance test

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

codecov · 2018-11-28T07:16:11Z

Codecov Report

Merging #33676 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #33676      +/-   ##
============================================
- Coverage     64.35%   64.35%   -0.01%     
  Complexity    18307    18307              
============================================
  Files          1195     1195              
  Lines         69241    69240       -1     
  Branches       1276     1276              
============================================
- Hits          44561    44560       -1     
  Misses        24308    24308              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	`52.98% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`65.67% <ø> (-0.01%)`	`18307 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
...eratedfilesharing/lib/Controller/OcmController.php	`66.06% <0%> (-0.21%)`	`30% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47da212...eeb2a91. Read the comment docs.

phil-davis · 2018-11-28T07:27:30Z

3 files in config folder have changed their permissions. That needs to be reverted.

phil-davis · 2018-11-28T07:35:26Z

Now the commit message says: [tx-robot] updated from transifex
Some problem when doing a rebase?
Next time you need to change something, fix the commit message also.

phil-davis

Stuff I found so far to the end of apiProvisioning-v1 suite.

tests/acceptance/features/apiProvisioning-v1/addGroup.feature

tests/acceptance/features/apiProvisioning-v1/addToGroup.feature

tests/acceptance/features/apiProvisioning-v1/deleteGroup.feature

tests/acceptance/features/apiProvisioning-v1/removeSubAdmin.feature

tests/acceptance/features/apiFederation/federated.feature

tests/acceptance/features/apiProvisioning-v1/addGroup.feature

tests/acceptance/features/apiShareOperations/gettingShares.feature

tests/acceptance/features/bootstrap/Provisioning.php

phil-davis

review comments for apiProvisioning-v2 suite

tests/acceptance/features/apiProvisioning-v2/addGroup.feature

tests/acceptance/features/apiProvisioning-v2/addToGroup.feature

tests/acceptance/features/apiProvisioning-v2/removeSubAdmin.feature

phil-davis

Few more items

tests/acceptance/features/apiShareManagement/deleteShare.feature

tests/acceptance/features/apiShareOperations/accessToShare.feature

tests/acceptance/features/apiShareOperations/gettingShares.feature

phil-davis

2 more things

tests/acceptance/features/apiProvisioning-v1/deleteGroup.feature

tests/acceptance/features/apiShareManagement/deleteShare.feature

tests/acceptance/features/apiProvisioning-v2/removeSubAdmin.feature

phil-davis

I have reviewed it all now! There are just a few comments to be resolved, and get CI to pass.

tests/acceptance/features/bootstrap/Sharing.php

tests/acceptance/features/bootstrap/Provisioning.php

package-lock.json

phil-davis

Should be good now, if CI passes.

tests/acceptance/features/bootstrap/Sharing.php

tests/acceptance/features/bootstrap/Provisioning.php

paurakhsharma · 2018-11-30T09:33:47Z

@DeepDiver1975 Some issue with codecov. Can you please merge this. Thanks

phil-davis · 2018-11-30T11:04:19Z

@paurakhsharma please backport. You will need to think about step text in extra scenarios in stable10 that might need to be adjusted (e.g. user management). But maybe none of those are effected by this.

paurakhsharma · 2018-12-03T06:17:55Z

Backport on: #33721

paurakhsharma added 3 - To Review backport-request dev:acceptance-tests QA:team labels Nov 28, 2018

paurakhsharma added this to the development milestone Nov 28, 2018

paurakhsharma self-assigned this Nov 28, 2018

paurakhsharma requested review from phil-davis and individual-it November 28, 2018 06:39

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from 6e37dd1 to fa427c0 Compare November 28, 2018 07:15

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from fa427c0 to bdd62b1 Compare November 28, 2018 07:29

phil-davis reviewed Nov 28, 2018

View reviewed changes

individual-it requested changes Nov 28, 2018

View reviewed changes

phil-davis reviewed Nov 28, 2018

View reviewed changes

paurakhsharma force-pushed the refactor-sents-HTTP-method branch 2 times, most recently from b897225 to d195d82 Compare November 28, 2018 10:29

phil-davis reviewed Nov 28, 2018

View reviewed changes

tests/acceptance/features/apiProvisioning-v1/deleteGroup.feature Outdated Show resolved Hide resolved

tests/acceptance/features/apiShareManagement/deleteShare.feature Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from d195d82 to 07b92d9 Compare November 28, 2018 10:36

phil-davis reviewed Nov 28, 2018

View reviewed changes

tests/acceptance/features/apiProvisioning-v2/removeSubAdmin.feature Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from 07b92d9 to 5b826d1 Compare November 28, 2018 10:55

phil-davis reviewed Nov 29, 2018

View reviewed changes

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch 2 times, most recently from 489e74c to dbd3ba6 Compare November 29, 2018 04:47

phil-davis requested changes Nov 29, 2018

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from dbd3ba6 to 2a8826f Compare November 29, 2018 06:36

phil-davis approved these changes Nov 29, 2018

View reviewed changes

individual-it requested changes Nov 29, 2018

View reviewed changes

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from 2a8826f to cadfdcf Compare November 29, 2018 08:18

individual-it requested changes Nov 29, 2018

View reviewed changes

tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved

tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved

paurakhsharma force-pushed the refactor-sents-HTTP-method branch 2 times, most recently from ffb578a to 24aacb9 Compare November 29, 2018 11:04

Refactor sends HTTP method to use specific methods

eeb2a91

paurakhsharma force-pushed the refactor-sents-HTTP-method branch from 24aacb9 to eeb2a91 Compare November 30, 2018 05:26

individual-it approved these changes Nov 30, 2018

View reviewed changes

PVince81 merged commit c136534 into master Nov 30, 2018

PVince81 deleted the refactor-sents-HTTP-method branch November 30, 2018 15:58

paurakhsharma mentioned this pull request Dec 3, 2018

[stable10] refactor sents http method #33721

Merged

paurakhsharma removed the backport-request label Dec 3, 2018

lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor sends HTTP method to use specific methods #33676

Refactor sends HTTP method to use specific methods #33676

paurakhsharma commented Nov 28, 2018

codecov bot commented Nov 28, 2018 •

edited

Loading

phil-davis commented Nov 28, 2018

phil-davis commented Nov 28, 2018

phil-davis left a comment

phil-davis left a comment

phil-davis left a comment

phil-davis left a comment

phil-davis left a comment

phil-davis left a comment

paurakhsharma commented Nov 30, 2018

phil-davis commented Nov 30, 2018

paurakhsharma commented Dec 3, 2018

Refactor sends HTTP method to use specific methods #33676

Refactor sends HTTP method to use specific methods #33676

Conversation

paurakhsharma commented Nov 28, 2018

Description

How Has This Been Tested?

Types of changes

Checklist:

codecov bot commented Nov 28, 2018 • edited Loading

Codecov Report

phil-davis commented Nov 28, 2018

phil-davis commented Nov 28, 2018

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis left a comment

Choose a reason for hiding this comment

paurakhsharma commented Nov 30, 2018

phil-davis commented Nov 30, 2018

paurakhsharma commented Dec 3, 2018

codecov bot commented Nov 28, 2018 •

edited

Loading