[master] Cannot upgrade from stable10 to master due to max-version

[PVince81]

As agreed in #33360, we skip max-version check for the git and daily channel on install.

We should also do so when running occ upgrade and any related operations.

Currently upgrading from stable10 to master gives errors:

2018-12-07T14:19:21+00:00 Repair warning: You have incompatible or missing apps enabled that could not be found or updated via the marketplace.                                                                                                                               
2018-12-07T14:19:21+00:00 Repair warning: Please install or update the following apps manually or disable them with:
occ app:disable activity                                                                                                               
occ app:disable files_texteditor                                                                                                       
occ app:disable files_videoplayer                                                                                                      
occ app:disable market                                                                                                                 
occ app:disable notifications                                                                                                          
2018-12-07T14:19:21+00:00 Repair warning: For manually updating, see https://doc.owncloud.org/server/11.0/go.php?to=admin-marketplace-apps                                                                                                                                    
2018-12-07T14:19:21+00:00 OC\RepairException: Upgrade is not possible
2018-12-07T14:19:21+00:00 Update failed

@DeepDiver1975 FYI

[PVince81]

@phil-davis FYI, I think you observed this as well in CI

[phil-davis]

@PVince81 yes, I had similar problems when messing around switching branches with varying oC versions.

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @VicDeo.

Possibly related issues are #1520 (Upgrade from stable45 to master broken), #8973 (Lost permissions after upgrade from stable6 to master), #31455 ([stable10][master] Session is not validated), #32687 ([stable10] Backport of languages from master), and #31155 ([stable10] Backport of languages from master).

[VicDeo]

https://github.com/owncloud/core/blob/master/lib/private/Updater.php#L111

[PVince81]

@VicDeo if quick fix, feel free to take over.

[PVince81]

Expected behavior is that if version.php contains "git" or "daily" as channel, we skip max-version check when installing or upgrading apps

[VicDeo]

@PVince81 >skip max-version check when installing or upgrading apps

we skip it currently. occ upgrade is about upgrading core, not apps.
Is it enough to adjust the repair step
https://github.com/owncloud/core/blob/master/lib/private/Repair/Apps.php#L210

if ($hasBlockingIncompatibleApps || $hasBlockingMissingApps) {
			// fail

as follows ($channelDailyOrGit is a pseudocode):

if ($channelDailyOrGit 
	&&($hasBlockingIncompatibleApps || $hasBlockingMissingApps)
) {
			// fail

[PVince81]

@VicDeo that should do, yeah. only skip blocking incompatible apps. missing apps should still block