No max version check for apps when using release channel git or daily #33360

DeepDiver1975 · 2018-10-30T12:02:37Z

Description

When installing owncloud from git or the daily release tar ball the max version requirement is no longer checked when installing/enabling apps

This will help with the development and release of apps in general

@patrickjahns as discussed long time back - we did go for the release channel and no env variable.

Related Issue

fixes Ability to skip max-version check in core for testing beta apps #31518

How Has This Been Tested?

enable an app with max version lower then 11.0
see if being enabled

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

PVince81

see review. also CI unhappy.

PVince81 · 2018-10-30T14:41:37Z

lib/private/App/DependencyAnalyzer.php

@@ -312,7 +312,7 @@ private function analyzeOC(array $dependencies, array $appInfo) {
 				$missing[] = (string)$this->l->t('ownCloud %s or higher is required.', $minVersion);
 			}
 		}
-		if ($maxVersion !== null) {
+		if ($maxVersion !== null && !\in_array(\OCP\Util::getChannel(), ['git', 'daily'])) {


we usually add , true at the end of in_array for strict comparison.
wonder if our style checkers can verify this

PVince81 · 2018-10-30T14:41:44Z

lib/private/legacy/app.php

@@ -936,6 +936,7 @@ public static function isAppCompatible($ocVersion, $appInfo) {
 		}

 		if (!empty($requireMax)
+			&& !\in_array(\OCP\Util::getChannel(), ['git', 'daily'])


codecov · 2018-10-30T15:08:34Z

Codecov Report

Merging #33360 into master will increase coverage by 16.18%.
The diff coverage is 52.54%.

@@              Coverage Diff              @@
##             master   #33360       +/-   ##
=============================================
+ Coverage     47.88%   64.06%   +16.18%     
- Complexity        0    18277    +18277     
=============================================
  Files           109     1190     +1081     
  Lines         10448    69044    +58596     
  Branches       1271     1271               
=============================================
+ Hits           5003    44234    +39231     
- Misses         5075    24440    +19365     
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	`52.88% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`65.36% <52.54%> (+28.44%)`	`18277 <27> (+18277)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/base.php	`5.98% <0%> (ø)`	`125 <0> (?)`
lib/private/Repair/Apps.php	`7.28% <0%> (ø)`	`44 <0> (?)`
lib/private/App/DependencyAnalyzer.php	`97.26% <100%> (ø)`	`60 <0> (?)`
lib/private/Server.php	`86.3% <100%> (ø)`	`253 <0> (?)`
lib/private/Installer.php	`49.12% <100%> (ø)`	`87 <0> (?)`
lib/private/App/AppManager.php	`85.84% <100%> (ø)`	`83 <6> (?)`
lib/private/legacy/app.php	`65.72% <42.85%> (ø)`	`182 <11> (?)`
lib/private/App/Platform.php	`37.5% <45.45%> (ø)`	`11 <10> (?)`
apps/files_external/lib/config.php	`16.39% <0%> (-22.5%)`	`13% <0%> (+13%)`
apps/updatenotification/templates/admin.php	`0% <0%> (ø)`	`0% <0%> (?)`
... and 1081 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aacf9e...a570d37. Read the comment docs.

lib/private/legacy/app.php

DeepDiver1975 · 2018-11-02T08:29:21Z

@ownclouders rebase

ownclouders · 2018-11-02T08:29:23Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

ownclouders · 2018-11-02T08:30:37Z

Automated rebase with GitMate.io was successful! 🎉

DeepDiver1975 · 2018-11-02T10:50:31Z

@ownclouders rebase

ownclouders · 2018-11-02T10:50:33Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

ownclouders · 2018-11-02T10:51:45Z

Automated rebase with GitMate.io was successful! 🎉

PVince81 · 2018-11-02T15:30:39Z

lib/private/legacy/app.php

@@ -239,7 +245,7 @@ public static function isType($app, $types) {
 		}
 		$appTypes = self::getAppTypes($app);
 		foreach ($types as $type) {
-			if (\array_search($type, $appTypes) !== false) {
+			if (\array_search($type, $appTypes, true)) {


for some strange reason, received shares don't appear in this PR.

Reverting this line to its previous state makes it work.

Maybe this disturbs the loading of apps by types and files_sharing maybe doesn't load at the right moment.

PVince81

Rechecked the code, looks good now 👍

DeepDiver1975 · 2018-11-02T16:16:30Z

@PVince81 I just added 3 more type safety fixes - will squash after CI being green ... THX

PVince81 · 2018-12-07T14:22:00Z

seems we missed some bits #33819

DeepDiver1975 added the 3 - To Review label Oct 30, 2018

DeepDiver1975 self-assigned this Oct 30, 2018

DeepDiver1975 requested a review from PVince81 October 30, 2018 12:02

PVince81 reviewed Oct 30, 2018

View reviewed changes

DeepDiver1975 force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch from b54f892 to 176a3a4 Compare October 30, 2018 15:08

DeepDiver1975 force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch 2 times, most recently from 23da368 to 7e8e859 Compare October 31, 2018 10:38

PVince81 reviewed Oct 31, 2018

View reviewed changes

lib/private/legacy/app.php Outdated Show resolved Hide resolved

ownclouders force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch from 7e8e859 to 7a2dd6c Compare November 2, 2018 08:30

ownclouders force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch from 7a2dd6c to 49cf33f Compare November 2, 2018 10:51

DeepDiver1975 force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch 3 times, most recently from 65a741f to 6b3eb0f Compare November 2, 2018 15:18

PVince81 reviewed Nov 2, 2018

View reviewed changes

PVince81 approved these changes Nov 2, 2018

View reviewed changes

No max version check for apps when using release channel git or daily

a570d37

DeepDiver1975 force-pushed the feature/ignore-max-version-check-on-git-and-daily-release-channel branch from fed93b2 to a570d37 Compare November 2, 2018 16:51

DeepDiver1975 merged commit a7cfcab into master Nov 5, 2018

DeepDiver1975 deleted the feature/ignore-max-version-check-on-git-and-daily-release-channel branch November 5, 2018 07:19

PVince81 mentioned this pull request Dec 7, 2018

[master] Cannot upgrade from stable10 to master due to max-version #33819

Closed

VicDeo mentioned this pull request Dec 10, 2018

Bypass apps blocking for daily/git channel #33844

Merged

10 tasks

VicDeo mentioned this pull request Dec 11, 2018

[stable10] Bypass apps blocking for daily/git channel #33861

Merged

9 tasks

phil-davis mentioned this pull request Mar 29, 2019

[stable10] No max version check for apps when using release channel git or daily #34931

Closed

phil-davis added the only-in-master label Mar 29, 2019

phil-davis mentioned this pull request Aug 2, 2019

No max version check for apps when using release channel git or daily #35976

Closed

lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No max version check for apps when using release channel git or daily #33360

No max version check for apps when using release channel git or daily #33360

DeepDiver1975 commented Oct 30, 2018 •

edited

Loading

PVince81 left a comment

PVince81 Oct 30, 2018

PVince81 Oct 30, 2018

codecov bot commented Oct 30, 2018 •

edited

Loading

DeepDiver1975 commented Nov 2, 2018

ownclouders commented Nov 2, 2018

ownclouders commented Nov 2, 2018

DeepDiver1975 commented Nov 2, 2018

ownclouders commented Nov 2, 2018

ownclouders commented Nov 2, 2018

PVince81 Nov 2, 2018

PVince81 left a comment

DeepDiver1975 commented Nov 2, 2018

PVince81 commented Dec 7, 2018

No max version check for apps when using release channel git or daily #33360

No max version check for apps when using release channel git or daily #33360

Conversation

DeepDiver1975 commented Oct 30, 2018 • edited Loading

Description

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 Oct 30, 2018

Choose a reason for hiding this comment

PVince81 Oct 30, 2018

Choose a reason for hiding this comment

codecov bot commented Oct 30, 2018 • edited Loading

Codecov Report

DeepDiver1975 commented Nov 2, 2018

ownclouders commented Nov 2, 2018

ownclouders commented Nov 2, 2018

DeepDiver1975 commented Nov 2, 2018

ownclouders commented Nov 2, 2018

ownclouders commented Nov 2, 2018

PVince81 Nov 2, 2018

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

DeepDiver1975 commented Nov 2, 2018

PVince81 commented Dec 7, 2018

DeepDiver1975 commented Oct 30, 2018 •

edited

Loading

codecov bot commented Oct 30, 2018 •

edited

Loading