[stable10] Bump symfony v3.4.20 => v3.4.21

[phil-davis]

Description

https://symfony.com/blog/symfony-3-4-21-released

Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 0 installs, 14 updates, 0 removals
  - Updating symfony/debug (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/console (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/event-dispatcher (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/process (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/routing (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/translation (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/class-loader (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/filesystem (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/config (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/dependency-injection (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/finder (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/options-resolver (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/stopwatch (v3.4.20 => v3.4.21): Loading from cache
  - Updating symfony/yaml (v3.4.20 => v3.4.21): Loading from cache

Note: master PR is #34041

Motivation and Context

Keep up-to-date with patches of dependencies

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[DeepDiver1975]

I vote for merge for 10.1 - final decision is up to @PVince81

[codecov]

Codecov Report

Merging #34042 into stable10 will increase coverage by 0.74%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable10   #34042      +/-   ##
==============================================
+ Coverage       62.82%   63.56%   +0.74%     
- Complexity      19109    19113       +4     
==============================================
  Files            1264     1264              
  Lines           75114    75156      +42     
  Branches         1286     1286              
==============================================
+ Hits            47190    47774     +584     
+ Misses          27548    27006     -542     
  Partials          376      376

Flag	Coverage Δ	Complexity Δ
#javascript	53.32% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.66% <ø> (+0.82%)	19113 <ø> (+4)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Cache/HomePropagator.php	88.88% <0%> (-11.12%)	3% <0%> (ø)
apps/files/lib/Command/Scan.php	71.84% <0%> (-9.39%)	62% <0%> (ø)
lib/private/Installer.php	48.94% <0%> (-0.18%)	93% <0%> (+4%)
lib/private/Files/View.php	84.47% <0%> (+0.3%)	380% <0%> (ø)	⬇️
apps/dav/lib/Connector/Sabre/File.php	82.52% <0%> (+0.64%)	115% <0%> (ø)	⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php	91.34% <0%> (+0.96%)	68% <0%> (ø)	⬇️
lib/private/Files/Cache/Cache.php	97.56% <0%> (+1.82%)	105% <0%> (ø)	⬇️
lib/private/AllConfig.php	93.15% <0%> (+2.05%)	43% <0%> (ø)	⬇️
lib/private/Share/Share.php	71.1% <0%> (+2.27%)	502% <0%> (ø)	⬇️
apps/files_versions/lib/Storage.php	71.39% <0%> (+2.4%)	104% <0%> (ø)	⬇️
... and 31 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1465b0...fdc3d0e. Read the comment docs.

[codecov]

Codecov Report

Merging #34042 into stable10 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             stable10   #34042   +/-   ##
===========================================
  Coverage       63.47%   63.47%           
  Complexity      19118    19118           
===========================================
  Files            1264     1264           
  Lines           75180    75180           
  Branches         1288     1288           
===========================================
  Hits            47722    47722           
  Misses          27080    27080           
  Partials          378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.31% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.56% <ø> (ø)	19118 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6aac23...b022a64. Read the comment docs.

[phil-davis]

This is getting https://drone.owncloud.com/owncloud/core/14331/596

    And user "user1" from server "REMOTE" shares "/simple-folder (2)" with user "user2" from server "LOCAL" using the sharing API # FederationContext::userFromServerSharesWithUserFromServerUsingTheSharingAPI()
    And the user sets the sharing permissions of "user2@%local_server%/ (federated)" for "simple-folder (2)" using the webUI to   # WebUISharingContext::theUserSetsTheSharingPermissionsOfForOnTheWebUI()
      | edit | no |
      SensioLabs\Behat\PageObjectExtension\PageObject\Exception\ElementNotFoundException: Page\FilesPageElement\SharingDialog::setSharingPermissions xpath .//*[@id='shareWithList']//*[@class='has-tooltip username' and .='user2@https://server/ (federated)']/.. could not find share permissions field for user user2@https://server/ (federated) in /drone/src/tests/acceptance/features/lib/OwncloudPage.php:821

--- Failed scenarios:

    /drone/src/tests/acceptance/features/webUISharingExternal/federationSharing.feature:201
    /drone/src/tests/acceptance/features/webUISharingExternal/federationSharing.feature:219

46 scenarios (44 passed, 2 failed)
474 steps (460 passed, 2 failed, 12 skipped)

These scenarios were added by master PR #33506 and backported to stable10 by PR #34172
It passes in master which has symfony 3.4.21, but fails here attempting to bump symfony to 3.4.21 in stable10 ???

PR #34180 has a fresh attempt at this - let's see what CI thinks about it - that passes.

Now I have restarted drone CI for this PR.

[phil-davis]

I rebased to latest stable10, and compared the diff of composer.lock with PR #34180 and the diffs are the same. CI passed this time. Maybe there is just some intermittent timing issue with those new scenarios.

[phil-davis]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉